Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forge 1.20.1] Mod is breaking JER Integration #95

Open
vizthex123 opened this issue Apr 30, 2024 · 8 comments
Open

[Forge 1.20.1] Mod is breaking JER Integration #95

vizthex123 opened this issue Apr 30, 2024 · 8 comments

Comments

@vizthex123
Copy link

Already reported it to the JER devs, but he said it seems to be an issue with this mod so I figured I'd post here.

@AlasDiablo
Copy link

AlasDiablo commented May 1, 2024

JER Integration not JER. ^^'

More information for 0rc1nus about the problem:

From what I have seen during my debug is that JER is trying to get every biome but when one of the galosphere biomes is called, the value of the registery key is null causing an unrecoverable crash.

I don't know if the problems are caused by me calling the registries system at the wrong time or if your mods have specific biomes.

Here is a small part of the log available in the issues on my addons.

java.lang.IllegalStateException: Unreferenced key: ResourceKey[minecraft:worldgen/biome / galosphere:lichen_caves]
  at net.minecraft.core.RegistrySetBuilder$BuildState.m_255228_(RegistrySetBuilder.java:126) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  at net.minecraft.core.RegistrySetBuilder.m_255144_(RegistrySetBuilder.java:61) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  at net.minecraft.data.registries.VanillaRegistries.m_255371_(VanillaRegistries.java:72) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  // JER Biome hook
  at jeresources.api.util.BiomeHelper.getBiome(BiomeHelper.java:20) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.BiomeRestriction.<init>(BiomeRestriction.java:46) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.BiomeRestriction.<clinit>(BiomeRestriction.java:19) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.Restriction.<init>(Restriction.java:23) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.Restriction.<clinit>(Restriction.java:6) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.entry.WorldGenEntry.<init>(WorldGenEntry.java:56) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.compatibility.api.WorldGenRegistryImpl.register(WorldGenRegistryImpl.java:64) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  // My mod hook to JER APi
  at fr.alasdiablo.jerintegration.util.JERIntegrationUtils.register(JERIntegrationUtils.java:20) ~[jerintegration-5.5.0.jar%23446!/:5.5.0]

@vizthex123 vizthex123 changed the title [Forge 1.20.1] Mod is breaking JER [Forge 1.20.1] Mod is breaking JER Integration May 1, 2024
@vizthex123
Copy link
Author

JER Integration not JER. ^^'
ah yeah, sorry. Changed the title.

More information for 0rc1nus about the problem:

From what I have seen during my debug is that JER is trying to get every biome but when one of the galosphere biomes is called, the value of the registery key is null causing an unrecoverable crash.

I don't know if the problems are caused by me calling the registries system at the wrong time or if your mods have specific biomes.

Here is a small part of the log available in the issues on my addons.

java.lang.IllegalStateException: Unreferenced key: ResourceKey[minecraft:worldgen/biome / galosphere:lichen_caves]
  at net.minecraft.core.RegistrySetBuilder$BuildState.m_255228_(RegistrySetBuilder.java:126) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  at net.minecraft.core.RegistrySetBuilder.m_255144_(RegistrySetBuilder.java:61) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  at net.minecraft.data.registries.VanillaRegistries.m_255371_(VanillaRegistries.java:72) ~[client-1.20.1-20230612.114412-srg.jar%23538!/:?]
  // JER Biome hook
  at jeresources.api.util.BiomeHelper.getBiome(BiomeHelper.java:20) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.BiomeRestriction.<init>(BiomeRestriction.java:46) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.BiomeRestriction.<clinit>(BiomeRestriction.java:19) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.Restriction.<init>(Restriction.java:23) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.api.restrictions.Restriction.<clinit>(Restriction.java:6) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.entry.WorldGenEntry.<init>(WorldGenEntry.java:56) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  at jeresources.compatibility.api.WorldGenRegistryImpl.register(WorldGenRegistryImpl.java:64) ~[JustEnoughResources-1.20.1-1.4.0.247.jar%23449!/:1.4.0.247]
  // My mod hook to JER APi
  at fr.alasdiablo.jerintegration.util.JERIntegrationUtils.register(JERIntegrationUtils.java:20) ~[jerintegration-5.5.0.jar%23446!/:5.5.0]

yeah, i dunno either. That's why i reported it to both devs (sometimes mods just don't wanna work together unless you add an extra line or two of code saying to lol)

if it's not fixable, perhaps you and the JER Integration dev could just have Galosphere blacklisted as a workaround?

@zHawky
Copy link

zHawky commented May 5, 2024

Did some research and found a small workaround, if you install Aether along with the Lost Content addon you will get a working version of JER.
Try this xD

@vizthex123
Copy link
Author

Did some research and found a small workaround, if you install Aether along with the Lost Content addon you will get a working version of JER. Try this xD

it doesn't fit the pack i'm making, but it's pretty funny that this is the workaround lol

@raffle2
Copy link

raffle2 commented Jul 6, 2024

I have the same problem when Galosphere is installed, JEI and all other addons work except for JER, none of the categories appear.

  • MC 1.20.1 - Forge 47.3.0
  • Galosphere-1.20.1-1.4.1-Forge.jar
  • JustEnoughResources-1.20.1-1.4.0.247.jar

@YaibaToKen
Copy link

Are there any news on this?

@zHawky
Copy link

zHawky commented Sep 10, 2024

Are there any news on this?

Make a choice either Galosphere or JER

@raffle2
Copy link

raffle2 commented Sep 11, 2024

Are there any news on this?

Like suggested above, actually installing Aether along with the Lost Content addon also magically worked for me, you can just disable all their content with jei/crafttweaker/kubejs if you're not interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants