Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make k_1 = 2, k_2 = 3 top-level constants #2

Open
therealyingtong opened this issue Jan 28, 2023 · 0 comments
Open

Make k_1 = 2, k_2 = 3 top-level constants #2

therealyingtong opened this issue Jan 28, 2023 · 0 comments

Comments

@therealyingtong
Copy link
Collaborator

k_1, k_2 are quadratic non-residues used to create distinct cosets in the permutation argument. This implementation hard-codes them to k_1 = 2, k_2 = 3; these should be declared as top-level constants.

Screenshot 2023-01-28 at 3 18 24 PM
luckyyang referenced this issue in Antalpha-Labs/baby-plonk Jul 7, 2023
@therealyingtong
Merge pull request #2 from nalinbhardwaj/nibnalin/devops
ab6b185 
Poetry, black, mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@therealyingtong