From 5830a138fd58012ca58d268adaab8153a69730b8 Mon Sep 17 00:00:00 2001 From: Paul-Henry Kajfasz Date: Tue, 16 Jul 2024 19:38:01 +0200 Subject: [PATCH 1/4] Reset head + add changelog workflow --- .github/workflows/changelog.yml | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/workflows/changelog.yml diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml new file mode 100644 index 0000000000..691725c89b --- /dev/null +++ b/.github/workflows/changelog.yml @@ -0,0 +1,27 @@ +name: Changelog + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + check-changelog: + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@main + with: + fetch-depth: 0 + + - name: Check if CHANGELOG.md is modified + run: | + # Get the list of changed files in the PR + changed_files=$(git diff --name-only origin/${{ github.event.pull_request.base.ref }}...${{ github.sha }}) + + # Check if CHANGELOG.md is in the list of changed files + if echo "$changed_files" | grep -q '^CHANGELOG.md$'; then + echo "CHANGELOG.md has been modified." + else + echo "::warning file=CHANGELOG.md::CHANGELOG.md has not been modified." + fi From cbc0f943624e34910c5c512f2ab28e3650f6200b Mon Sep 17 00:00:00 2001 From: Paul-Henry Kajfasz Date: Tue, 16 Jul 2024 21:02:57 +0200 Subject: [PATCH 2/4] Make job fail --- .github/workflows/changelog.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 691725c89b..224882abe4 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -24,4 +24,5 @@ jobs: echo "CHANGELOG.md has been modified." else echo "::warning file=CHANGELOG.md::CHANGELOG.md has not been modified." + exit 1 fi From b623e586460aca03cb126bd2279ee26704c355af Mon Sep 17 00:00:00 2001 From: Paul-Henry Kajfasz Date: Tue, 16 Jul 2024 22:09:39 +0200 Subject: [PATCH 3/4] Improve warning message --- .github/workflows/changelog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 224882abe4..45bd914cf3 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -23,6 +23,6 @@ jobs: if echo "$changed_files" | grep -q '^CHANGELOG.md$'; then echo "CHANGELOG.md has been modified." else - echo "::warning file=CHANGELOG.md::CHANGELOG.md has not been modified." + echo "::warning file=CHANGELOG.md::CHANGELOG.md has not been modified.\n This warning can be ignored if is has been explicitely decided not to log changes.\n Except in this situation, make sure to add log changes." exit 1 fi From 3492d011326f79e4bce3efd36d121279a2d13e05 Mon Sep 17 00:00:00 2001 From: Paul-Henry Kajfasz Date: Tue, 16 Jul 2024 22:11:28 +0200 Subject: [PATCH 4/4] update warning --- .github/workflows/changelog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 45bd914cf3..1de1b6372c 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -23,6 +23,6 @@ jobs: if echo "$changed_files" | grep -q '^CHANGELOG.md$'; then echo "CHANGELOG.md has been modified." else - echo "::warning file=CHANGELOG.md::CHANGELOG.md has not been modified.\n This warning can be ignored if is has been explicitely decided not to log changes.\n Except in this situation, make sure to add log changes." + echo $'::warning file=CHANGELOG.md::CHANGELOG.md has not been modified.\n This warning can be ignored if is has been explicitely decided not to log changes.\n Except in this situation, make sure to add log changes.' exit 1 fi