Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(continuations): linked list should store storage values directly #398

Closed
Nashtare opened this issue Jul 16, 2024 · 1 comment
Closed

perf(continuations): linked list should store storage values directly #398

Nashtare opened this issue Jul 16, 2024 · 1 comment
Assignees
@LindaGuiga
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. performance Performance improvement related changes
Milestone
continuations v1 ...

Comments

@Nashtare
Copy link
Collaborator

We currently have a unified version of LinkedList for accounts and storage, where we store a ptr to the value.
This is necessary for accounts that aren't of fixed length, but storage values are always U256, and as such, we could store the values directly within the linked list.
@Nashtare Nashtare added performance Performance improvement related changes crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Jul 16, 2024
@Nashtare Nashtare added this to the zk-continuations - Q3 2024 milestone Jul 16, 2024
@LindaGuiga LindaGuiga self-assigned this Jul 16, 2024
@LindaGuiga LindaGuiga mentioned this issue Jul 23, 2024
Merged
@Nashtare
Copy link
Collaborator Author

Nashtare commented Aug 6, 2024

Implemented in #433.

@Nashtare Nashtare closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LindaGuiga LindaGuiga

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. performance Performance improvement related changes
Projects
Zero EVM
Status: Done
Milestone
continuations v1 (Q3 2024)
Development

No branches or pull requests
2 participants
@Nashtare @LindaGuiga