Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document uses of BASIC_SELL #52

Open
duncancmt opened this issue Dec 27, 2023 · 0 comments
Open

Document uses of BASIC_SELL #52

duncancmt opened this issue Dec 27, 2023 · 0 comments

Comments

@duncancmt
Copy link
Collaborator

          Ah I see, so fees, deposit/withdraw wrapped native responsibilities got rolled up into the general `BASIC_SELL`. Now that I am aware of this the code makes more sense, in my mind I was still thinking historically where it just supported generic dexes, and WETH functionality would be added as a separate action.

We should document this intention as the current docs only mention that it sells to a generic pool that follow the approval, transferFrom interaction pattern.

I don't necessarily mind a fanciful BASIC_SELL, to save on codesize. It is less clear to an observer though, especially when used as a fee transfer mechanism rather than a sell.

Originally posted by @dekz in #45 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant