Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pragma solidity ^ #61

Open
bartleyg opened this issue Aug 30, 2018 · 1 comment · May be fixed by #66
Open

Use pragma solidity ^ #61

bartleyg opened this issue Aug 30, 2018 · 1 comment · May be fixed by #66
Labels
on hold

Comments

@bartleyg
Copy link

The contracts cannot currently compile when using a derived contract with pragma solidity ^0.4.24 because of the version difference and lack of the ^ in a few base contracts.

I see you are updating to solidity 0.4.24 in the cleanup branch which is very much welcome.

However, in that branch there are a few files that specify "pragma solidity 0.4.24" without the ^ carrot. Shouldn't these be "pragma solidity ^0.4.24" so that derived contracts can compile ERC777 these on future solidity versions after 0.4.24 when they come out?
@d10r d10r linked a pull request Nov 16, 2018 that will close this issue
Open
@0xjac
Copy link
Owner

0xjac commented Apr 4, 2019

This was actually discussed here. Pinning the version is intentional for the implementation for safety reasons.

I will admit that recently the solidity team has been spitting out new versions very quickly and this might make sense. I need some time to think about it.

@0xjac 0xjac added the on hold label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow use of compilers with higher minor version d10r/ERC777
2 participants
@0xjac @bartleyg