ERC1155 sale contract globalSaleDetails and tokenSaleDetails as view in interface #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got issue, when these 2 methods
globalSaleDetails()andtokenSaleDetails()wasn't generated in clients as read only methods.I checked the code for
ERC721and noticed one difference between these methods andsaleDetails()forERC721so i made this little change and it generated me expected client with read only methods.If the approach is wrong, then close this PR please.
https://github.com/0xsequence/contracts-library/blob/master/src/tokens/ERC721/utility/sale/IERC721Sale.sol#L55