Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): remove drfaddons dependency #208

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat(deps): remove drfaddons dependency #208

wants to merge 5 commits into from

Conversation

sumit4613
Copy link
Member

closes #110

@sumit4613 sumit4613 self-assigned this Oct 8, 2022
@sumit4613 sumit4613 marked this pull request as draft October 8, 2022 16:28
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 8, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.09%.

Quality metrics Before After Change
Complexity 2.87 ⭐ 2.45 ⭐ -0.42 👍
Method Length 59.36 ⭐ 61.07 ⭐ 1.71 👎
Working memory 5.50 ⭐ 5.59 ⭐ 0.09 👎
Quality 79.67% ⭐ 79.58% ⭐ -0.09% 👎
Other metrics Before After Change
Lines 2586 2756 170
Changed files Quality Before Quality After Quality Change
docs/conf.py 91.68% ⭐ 89.46% ⭐ -2.22% 👎
drf_user/init.py 51.03% 🙂 53.28% 🙂 2.25% 👍
drf_user/admin.py 85.69% ⭐ 81.60% ⭐ -4.09% 👎
drf_user/managers.py 72.89% 🙂 72.89% 🙂 0.00%
drf_user/models.py 92.25% ⭐ 91.46% ⭐ -0.79% 👎
drf_user/serializers.py 83.87% ⭐ 84.12% ⭐ 0.25% 👍
drf_user/urls.py 79.68% ⭐ 79.68% ⭐ 0.00%
drf_user/utils.py 73.42% 🙂 70.04% 🙂 -3.38% 👎
drf_user/views.py 61.45% 🙂 64.24% 🙂 2.79% 👍
drf_user/signals/handlers.py 68.93% 🙂 73.57% 🙂 4.64% 👍
example/demo_app/settings.py 62.05% 🙂 62.10% 🙂 0.05% 👍
example/demo_app/urls.py 64.77% 🙂 64.77% 🙂 0.00%
tests/settings.py 70.20% 🙂 70.30% 🙂 0.10% 👍
tests/test_models.py 94.70% ⭐ 94.70% ⭐ 0.00%
tests/test_utils.py 91.45% ⭐ 90.98% ⭐ -0.47% 👎
tests/test_views.py 87.80% ⭐ 87.04% ⭐ -0.76% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
drf_user/init.py update_user_settings 34 ⛔ 132 😞 8 🙂 43.54% 😞 Refactor to reduce nesting. Try splitting into smaller methods
drf_user/views.py OTPView.post 12 🙂 210 ⛔ 11 😞 44.28% 😞 Try splitting into smaller methods. Extract out complex expressions
drf_user/views.py OTPLoginView.post 5 ⭐ 231 ⛔ 9 🙂 53.42% 🙂 Try splitting into smaller methods
drf_user/utils.py send_message 9 🙂 158 😞 8 🙂 57.58% 🙂 Try splitting into smaller methods
drf_user/utils.py send_otp 2 ⭐ 111 🙂 11 😞 63.64% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot mentioned this pull request Oct 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sumit4613 sumit4613

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove drf-addons dependency.
1 participant
@sumit4613