Delete replace-namespace.sh after replacements are done

[ocean90]

Is your enhancement related to a problem? Please describe.

I noticed that replace-namespace.sh is part of the shipped plugin but it's not used on production. I'm suggesting to remove it from the plugin after the replacements are done.

I'm not sure if it should be added to https://github.com/10up/wp-compat-validation-tool/blob/aff3672e7ab5413fa99eab65998675f8da65eea3/replace-namespace.sh#L22 or

simple-local-avatars/composer.json

Lines 38 to 43 in c5f0981

	"post-install-cmd": [
	"./10up-lib/wp-compat-validation-tool/replace-namespace.sh SimpleLocalAvatarsValidator"
	],
	"post-update-cmd": [
	"./10up-lib/wp-compat-validation-tool/replace-namespace.sh SimpleLocalAvatarsValidator"
	]

.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[jeffpaul]

@faisal-alvi this sound about right to you?

[gsarig]

@jeffpaul This was introduced here. I'm not sure if I miss any other context, but it seems to me that the specific script is only needed during the build, and doesn't have to be part of the production. If that's the case, I wonder if the simplest way to exclude it is by adding it to .distignore.

[faisal-alvi]

@gsarig I agree, the replace-namespace.sh script should only be used for the development version of the plugin. Adding it to the .distignore sounds fine.