Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for shorthand rgb values #2

Open
10xJSChad opened this issue Dec 24, 2024 · 1 comment
Open

add support for shorthand rgb values #2

10xJSChad opened this issue Dec 24, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@10xJSChad
Copy link
Owner

for example, "fill:#0f0" would not work with svgshift.
"fill:rgb(0, 255, 0)" would also not work but that's a bit more of a pain to fix, and also I'm pretty sure tools like svgo convert all of those to hex, so at least there's a workaround there. No workaround that I'm aware of for shorthand values though.

@10xJSChad 10xJSChad added the good first issue Good for newcomers label Dec 24, 2024
@10xJSChad
Copy link
Owner Author

shorthand hex values like "#ff0" are now supported, others like "rgb(x, x, x)" and regular color names like "red" are not.
you could have been able to work around this using svgo, but the problem there is that svgo would turn "#f00" into "red", which is not great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant