-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate image tags #3855
Comments
@beechnut , @cantsin , and @bpdesigns I've opened #3863 for this. There's about 100 left to do. (They seemed to make more as I went. 😅 ) Many of them are easy, but a few have conditional logic that I'm not sure how to interpolate. Since I'm staffed to a new project on Monday, I'll let it to the three of you to decide where to take this ticket and pull request. |
Thanks! I think we can find someone else to pick up where this left off. |
Just a small scope question: most of the raw Thank you! |
@beepdotgov , if you are working from #3863 I've already done a fair number of the @beechnut left a review comment about the CSS that is worth keeping in mind if you are doing the |
@beepdotgov The goal is to replace all the image tags with the shortcodes, to align with the practice in 18F/guides. Feel free to do it in several passes — there's a lot of content to be replaced. |
@beepdotgov Based on our conversation, I'm going to revoke my last comment — this ticket is only to set up shortcodes in layouts and partials. We'll do blog post images post-migration in #3864. |
@beechnut Today's chat was massively helpful. Thanks so much for talking through everything! Working on getting the latest into my workspace now, and then I'll finish up the shortcode migration in the layouts/partials. |
Okay! Per this morning's chat, I:
@beechnut Would it be helpful if I took a look at the open notes on the #3863 PR? |
@beepdotgov Yes please! There are a few changes there that need to be reverted or otherwise reviewed. |
Done, @beechnut! Left a question for you on one, and left another one open for review; everything else has been closed out. Thanks again for all your help today! |
Images are currently referenced mostly through
<img>
tags, but we should convert them to usingimage
/image_with_class
shortcodes, in keeping with 18F/guides convention.Acceptance criteria
The text was updated successfully, but these errors were encountered: