Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate timecard save behavior #1613

Open
jduss4 opened this issue May 18, 2023 · 1 comment
Open

Investigate timecard save behavior #1613

jduss4 opened this issue May 18, 2023 · 1 comment

Comments

@jduss4
Copy link
Contributor

jduss4 commented May 18, 2023

Related to epic #1500 but not a prerequisite nor part of the epic.

We want to explore if it would make sense for saved timecards to run calculate_hours when a timecard is submitted == True.

Background:

When a timecard is saved, the behavior is different depending on whether or not it is a new timecard. In Tock, timecards for each user are automatically created for each reporting period and are saved with basic information about the user's billable expectation, organization, and unit.

When the user then saves their timecard to return later or submits their timecard, calculate_hours is called which populates the timecard with information like the target_hours, sum of billable time spent, sum of billable weekly allocation, and utilization %.

Note: in the admin interface one can create a new timecard with timecard objects but calculate_hours will not be run, as it is a brand new timecard, and you will need to hit save a second time to run the method.

It may make more sense for calculate_hours to be run if a timecard is actually marked as submitted. Investigate if there are unintended consequences of this change and how it might impact the user experience.

@alexbielen
Copy link

Discussed with Jess and we feel this is low priority but still a good idea to fix at some point.

We're going to move this into the TLC Icebox for now. In the meantime, if you find another way to get this work done feel free to choose that path. If you do find a different path to getting the work done and no longer want TLC crew help, please remove the issue from our project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants