Skip to content

Commit 28c5440

Browse files
committed
Converting models to use more user friendly names
1 parent 68907ba commit 28c5440

File tree

11 files changed

+212
-212
lines changed

11 files changed

+212
-212
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,12 @@ Create an item in the specified vault.
9191

9292
```python
9393
# Example item creation. Create an item with your desired arguments.
94-
item = onepasswordconnectsdk.models.FullItem(vault=ItemVault(id="av223f76ydutdngislnkbz6z5u"),
94+
item = onepasswordconnectsdk.models.Item(vault=ItemVault(id="av223f76ydutdngislnkbz6z5u"),
9595
id="kp2td65r4wbuhocwhhijpdbfqq",
9696
title="newtitle",
9797
category="LOGIN",
9898
tags=["1password-connect"],
99-
fields=[FullItemAllOfFields(value="new_user",
99+
fields=[Field(value="new_user",
100100
purpose="USERNAME")],
101101
)
102102
client.create_item("{vault_id}", item)
@@ -108,12 +108,12 @@ Item the item with the specified item and vault ids. The existing item will be o
108108

109109
```python
110110
# Example item creation. Create an item with your desired arguments.
111-
item = onepasswordconnectsdk.models.FullItem(vault=ItemVault(id="av223f76ydutdngislnkbz6z5u"),
111+
item = onepasswordconnectsdk.models.Item(vault=ItemVault(id="av223f76ydutdngislnkbz6z5u"),
112112
id="kp2td65r4wbuhocwhhijpdbfqq",
113113
title="newtitle",
114114
category="LOGIN",
115115
tags=["1password-connect"],
116-
fields=[FullItemAllOfFields(value="new_user",
116+
fields=[Field(value="new_user",
117117
purpose="USERNAME")],
118118
)
119119
client.update_item("{item_id}", "{vault_id}", item)

src/onepasswordconnectsdk/client.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import datetime
99
from requests.exceptions import HTTPError
1010
import onepasswordconnectsdk
11-
from onepasswordconnectsdk.models import FullItem, ItemVault
11+
from onepasswordconnectsdk.models import Item, ItemVault
1212

1313

1414
ENV_SERVICE_ACCOUNT_JWT_VARIABLE = "OP_CONNECT_TOKEN"
@@ -73,7 +73,7 @@ def get_item(self, item_id: str, vault_id: str):
7373
f"Unable to retrieve item. Received {response.status_code}\
7474
for {url} with message: {response.json().get('message')}"
7575
)
76-
return self.deserialize(response.content, "FullItem")
76+
return self.deserialize(response.content, "Item")
7777

7878
def get_item_by_title(self, title: str, vault_id: str):
7979
"""Get a specific item by title
@@ -102,7 +102,7 @@ def get_item_by_title(self, title: str, vault_id: str):
102102
title {title}"
103103
)
104104

105-
return self.deserialize(response.content, "list[Item]")[0]
105+
return self.deserialize(response.content, "list[SummaryItem]")[0]
106106

107107
def get_items(self, vault_id: str):
108108
"""Returns a list of item summaries for the specified vault
@@ -115,7 +115,7 @@ def get_items(self, vault_id: str):
115115
from the 1Password Connect API
116116
117117
Returns:
118-
List[Item]: A list of summarized items
118+
List[SummaryItem]: A list of summarized items
119119
"""
120120
url = f"/v1/vaults/{vault_id}/items"
121121

@@ -128,7 +128,7 @@ def get_items(self, vault_id: str):
128128
for {url} with message: {response.json().get('message')}"
129129
)
130130

131-
return self.deserialize(response.content, "list[Item]")
131+
return self.deserialize(response.content, "list[SummaryItem]")
132132

133133
def delete_item(self, item_id: str, vault_id: str):
134134
"""Deletes a specified item from a specified vault
@@ -153,19 +153,19 @@ def delete_item(self, item_id: str, vault_id: str):
153153
for {url} with message: {response.json().get('message')}"
154154
)
155155

156-
def create_item(self, vault_id: str, item: FullItem):
156+
def create_item(self, vault_id: str, item: Item):
157157
"""Creates an item at the specified vault
158158
159159
Args:
160160
vault_id (str): The id of the vault in which add the item to
161-
item (FullItem): The item to create
161+
item (Item): The item to create
162162
163163
Raises:
164164
FailedToRetrieveItemException: Thrown when a HTTP error is returned
165165
from the 1Password Connect API
166166
167167
Returns:
168-
FullItem: The created item
168+
Item: The created item
169169
"""
170170

171171
url = f"/v1/vaults/{vault_id}/items"
@@ -178,22 +178,22 @@ def create_item(self, vault_id: str, item: FullItem):
178178
f"Unable to post item. Received {response.status_code}\
179179
for {url} with message: {response.json().get('message')}"
180180
)
181-
return self.deserialize(response.content, "FullItem")
181+
return self.deserialize(response.content, "Item")
182182

183-
def update_item(self, item_uuid: str, vault_id: str, item: FullItem):
183+
def update_item(self, item_uuid: str, vault_id: str, item: Item):
184184
"""Update the specified item at the specified vault.
185185
186186
Args:
187187
item_uuid (str): The id of the item in which to update
188188
vault_id (str): The id of the vault in which to update the item
189-
item (FullItem): The updated item
189+
item (Item): The updated item
190190
191191
Raises:
192192
FailedToRetrieveItemException: Thrown when a HTTP error is returned
193193
from the 1Password Connect API
194194
195195
Returns:
196-
FullItem: The updated item
196+
Item: The updated item
197197
"""
198198
url = f"/v1/vaults/{vault_id}/items/{item_uuid}"
199199
item.id = item_uuid
@@ -207,7 +207,7 @@ def update_item(self, item_uuid: str, vault_id: str, item: FullItem):
207207
f"Unable to post item. Received {response.status_code}\
208208
for {url} with message: {response.json().get('message')}"
209209
)
210-
return self.deserialize(response.content, "FullItem")
210+
return self.deserialize(response.content, "Item")
211211

212212
def get_vault(self, vault_id: str):
213213
"""Returns the vault with the given vault_id

src/onepasswordconnectsdk/config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
from typing import List, Dict
44
from onepasswordconnectsdk.client import Client
55
from onepasswordconnectsdk.models import (
6+
SummaryItem,
67
Item,
7-
FullItem,
88
ParsedField,
99
ParsedItem,
10-
FullItemAllOfSections,
10+
Section,
1111
)
1212
from onepasswordconnectsdk.models.constants import (
1313
ITEM_TAG,
@@ -173,7 +173,7 @@ def _set_values_for_item(
173173
parsed_item.item_title, parsed_item.vault_uuid
174174
)
175175
# Fetching the full item
176-
item: FullItem = client.get_item(summary_item.id, parsed_item.vault_uuid)
176+
item: Item = client.get_item(summary_item.id, parsed_item.vault_uuid)
177177

178178
sections = _convert_sections_to_dict(item.sections)
179179

@@ -215,7 +215,7 @@ def _set_values_for_item(
215215
)
216216

217217

218-
def _convert_sections_to_dict(sections: List[FullItemAllOfSections]):
218+
def _convert_sections_to_dict(sections: List[Section]):
219219
if not sections:
220220
return {}
221221
section_dict = {section.label: section.id for section in sections}

src/onepasswordconnectsdk/models/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
# import models into model package
99
from onepasswordconnectsdk.models.error import Error
10-
from onepasswordconnectsdk.models.full_item import FullItem
11-
from onepasswordconnectsdk.models.full_item_all_of import FullItemAllOf
12-
from onepasswordconnectsdk.models.full_item_all_of_fields import FullItemAllOfFields
13-
from onepasswordconnectsdk.models.full_item_all_of_section import FullItemAllOfSection
14-
from onepasswordconnectsdk.models.full_item_all_of_sections import FullItemAllOfSections
1510
from onepasswordconnectsdk.models.item import Item
11+
from onepasswordconnectsdk.models.item_details import ItemDetails
12+
from onepasswordconnectsdk.models.field import Field
13+
from onepasswordconnectsdk.models.field_section import FieldSection
14+
from onepasswordconnectsdk.models.section import Section
15+
from onepasswordconnectsdk.models.summary_item import SummaryItem
1616
from onepasswordconnectsdk.models.item_urls import ItemUrls
1717
from onepasswordconnectsdk.models.item_vault import ItemVault
1818
from onepasswordconnectsdk.models.parsed_field import ParsedField

0 commit comments

Comments
 (0)