Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export-env security risk #79

Open
datbth opened this issue Oct 2, 2024 · 0 comments
Open

export-env security risk #79

datbth opened this issue Oct 2, 2024 · 0 comments

Comments

@datbth
Copy link

datbth commented Oct 2, 2024

Currently, export-env has a default value of true and is also suggested to be set as true in README.

While it is convenient to do so, it makes the secrets available as ENVs to all the later steps, including the third-party GitHub Actions. This can easily lead to leaking secrets when using malicious or vulnerable GitHub actions.
Thus, I think it should at least be mentioned in README.

Additionally, the usage of the step outputs of load-secrets-action should also be documented.

@datbth datbth changed the title export-envs security risk export-env security risk Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant