Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ResourceContainer from class to functional component #397

Open
jocelynn1uphealth opened this issue Mar 24, 2023 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@jocelynn1uphealth
Copy link
Contributor

Background:

Functional components are smaller, more performant, and more modern than legacy class-based ones. Let's convert the ResourceContainer class to a functional component to improve the bundle size + performance of this library

Expected Behavior:

  • No user-facing changes will result from this change.
  • The ResourceContainer class is gone and replaced with a functional component of the same name.
  • All stories + supporting documentation are updated
@jocelynn1uphealth jocelynn1uphealth added the good first issue Good for newcomers label Mar 24, 2023
@patrick-1upHealth
Copy link

@jocelynn1uphealth Looks like this one is already a class-based component. We'll still need to revisit this one after the TypeScript issue is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

2 participants