Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIの修正 #94

Closed
24ik opened this issue Mar 2, 2024 · 4 comments · Fixed by #108
Closed

APIの修正 #94

24ik opened this issue Mar 2, 2024 · 4 comments · Fixed by #108
Labels
breaking Breaking change enhancement New feature or request refactor Refactor code

Comments

@24ik
Copy link
Owner

24ik commented Mar 2, 2024

現状はobjectの公開メンバが多すぎるので減らすべき

特にsimulator, guiAppは動作に影響があるので適宜readonlyにするべき
@24ik 24ik added refactor Refactor code breaking Breaking change labels Mar 2, 2024
@24ik
Copy link
Owner Author

24ik commented Mar 2, 2024 •
edited
Loading

他の要検討事項：

  • nazo.rule 等でアクセスできるようなプロパティを追加してもいいかもしれない
  • pairsをmove後に削除しないようにしたので，originalは不要ではないか？
  • simulator, guiAppはref objectでもよいのでは？

@24ik 24ik added the enhancement New feature or request label Mar 2, 2024
@24ik
Copy link
Owner Author

24ik commented Mar 13, 2024

0.13.0でcoreAPIの修正とあわせてoriginalを最低限修正してネクスト不具合修正を出す
0.14.0でAPIの完全な変更版リリース

@24ik
Copy link
Owner Author

24ik commented Mar 15, 2024

simulator.nextIndexは紛らわしいのでnowIdxにする

@24ik
Copy link
Owner Author

24ik commented Mar 21, 2024

  • nazo.rule 等のプロパティはそれが妥当に読めるもののみ
  • originalは削除
  • ref objectにする必要性はない
  • nowIdxはoperatingIdxに

@24ik 24ik linked a pull request Mar 23, 2024 that will close this issue
Api #108
Merged
@24ik 24ik closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking change enhancement New feature or request refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Api 24ik/pon2
1 participant
@24ik