Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve UART mock #10

Closed
4 tasks done
2bndy5 opened this issue Aug 7, 2024 · 0 comments · Fixed by #14
Closed
4 tasks done

improve UART mock #10

2bndy5 opened this issue Aug 7, 2024 · 0 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@2bndy5
Copy link
Owner

2bndy5 commented Aug 7, 2024

Certain functions/attributes are not present in the mock busio.UART class:

  • UART.in_waiting should attempt to read the length of bytes in the next expected operation. Note, this shall not assert that the next expected operation is of type UARTRead.
  • UART.reset_input_buffer() should assert that a UARTFlush operation is expected. Note, the UARTFlush operation does not currently exist and should be introduced.
  • UART.timeout may be just a dummy attribute. Note, this could be used to check against a UART operation if the UART operations support a dummy wait or timeout attribute. Users should pass a None value to the UARTRead constructor.
  • UART.baudrate property should return the value given to the constructor. Note, this should be a read/write property.
@2bndy5 2bndy5 added the enhancement New feature or request label Aug 7, 2024
@2bndy5 2bndy5 linked a pull request Aug 7, 2024 that will close this issue
@2bndy5 2bndy5 mentioned this issue Aug 7, 2024
@2bndy5 2bndy5 closed this as completed in #14 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant