Skip to content

Commit d6d89f5

Browse files
committed
utoronto, terraform: refine comments slightly
1 parent d02bc52 commit d6d89f5

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

terraform/azure/projects/utoronto.tfvars

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
# IMPORTANT: Due to a restrictive network rule from storage.tf, we can't perform
2+
# "terraform plan" or "terraform apply" without a workaround.
3+
#
4+
# One known workaround is to allow your public IP temporarily as
5+
# discussed in https://github.com/2i2c-org/infrastructure/issues/890#issuecomment-1879072422.
6+
# This workaround is problematic as that may temporarily allow access
7+
# to storage by other actors with the same IP.
8+
#
19
tenant_id = "78aac226-2f03-4b4d-9037-b46d56c55210"
210
subscription_id = "ead3521a-d994-4a44-a68d-b16e35642d5b"
311
resourcegroup_name = "2i2c-utoronto-cluster"
@@ -16,17 +24,20 @@ node_pools = {
1624
{
1725
name : "core",
1826

19-
# FIXME: transition to "Standard_E2s_v5" nodes as they are large enough and
20-
# can more cheaply handle being forced to have 2-3 replicas for silly
21-
# reasons like three calico-typha pods. See
22-
# https://github.com/2i2c-org/infrastructure/issues/3592#issuecomment-1883269632.
27+
# FIXME: Transition to "Standard_E2s_v5" nodes as they are large enough to
28+
# for the biggest workload (prometheus-server) and can handle high
29+
# availability requirements better.
30+
#
31+
# We are currently forced to handle three calico-typha pods that
32+
# can't schedule on the same node, see https://github.com/2i2c-org/infrastructure/issues/3592#issuecomment-1883269632.
2333
#
2434
vm_size : "Standard_E4s_v3",
2535

36+
# core nodes doesn't need much disk space
2637
os_disk_size_gb : 40,
2738

28-
# FIXME: stop using persistent disks for the nodes, use the variable default
29-
# "Temporary" instead
39+
# FIXME: Stop using persistent disks for the nodes, use the variable default
40+
# "Temporary" instead by removing this line.
3041
kubelet_disk_type : "OS",
3142

3243
min : 1,

0 commit comments

Comments
 (0)