-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS clusters: get allowVolumeExpansion: true
by default in StorageClass, or document procedure to update it once
#2906
Comments
A lot of our prometheuses were down, so I did this now.
|
After that, I re-ran https://github.com/2i2c-org/infrastructure/actions/runs/5781619537 again, which completely passed this time. However, dynamic resizing only takes effect when the pod itself is recreated, so am doing that as well now. |
We add this unconditionally to all clusters for simplification, so we can set storageClass: gp3 for new clusters that come up on AWS without issue. This doesn't change the default, and does not change the storageclass in existing clusters. In addition to using gp3, it also sets reclaimPolicy to Retain, so if the PVC is deleted, it does not delete the PV or the underlying EBS volume. Ref 2i2c-org#2906 Ref 2i2c-org#2717
Given we've already manually done this for existing clusters, I think for new clusters, we should use #2941 and manage storageclass explicitly. This alleviates r2r concerns that @sgibson91 raised in #2718 as well as allows us to use the cheaper & better gp3 storageclass. |
We want our StorageClass resource to have
allowVolumeExpansion: true
, as that makes us able to increase the PVC's requested storage. This is a requirement for the troubleshooting docs here for example.I believe its not the default at least for AWS based clusters default StorageClass resource, but I think its the default for GCP based clusters.
The text was updated successfully, but these errors were encountered: