Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review https://github.com/jupyterhub/nbgitpuller/pull/359 #5059

Closed
2 tasks done
yuvipanda opened this issue Nov 13, 2024 · 1 comment
Closed
2 tasks done

Review https://github.com/jupyterhub/nbgitpuller/pull/359 #5059

yuvipanda opened this issue Nov 13, 2024 · 1 comment
Assignees

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Nov 13, 2024

jupyterhub/nbgitpuller#359 has been sitting for a bit, and it would be a great way to jump start our structured upstream OSS contribution process. It's a simple start because:

  1. There's a clear bug report of a specific problem
  2. The PR has a clear and veriiable fix that is possible to test

Suggested Steps

These are purely suggested steps, and need not be followed. Our goal is to see if this PR improves the project, and

  1. Setup a local dev environment of nbgitpuller
  2. Validate the error reported in Status page broken jupyterhub/nbgitpuller#358
  3. Pull Update style-sheet links to reflect those from jupyter-server jupyterhub/nbgitpuller#359 and test to see if that fixes the issue
  4. ??? We have to figure it out from here collectively :) Use your best judgement and ask questions!

Definition of done

@sgibson91
Copy link
Member

@agoose77 and I completed this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants