Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "open_pgrouting.js" necessary? #12

Closed
gioman opened this issue Feb 19, 2024 · 3 comments
Closed

Is "open_pgrouting.js" necessary? #12

gioman opened this issue Feb 19, 2024 · 3 comments
Assignees

Comments

@gioman
Copy link

gioman commented Feb 19, 2024

I just found that "open_pgrouting.js" inside "media/js/pgrouting" in

https://demo.lizmap.com/lizmap/index.php/view/media/getMedia?repository=modules&project=pgrouting&path=/media/pgrouting.zip

is not only not necessary to have the routing icon show in the LMWC toolbar, but also if the file is there the icon to show the layers do not appear in the toolbar.

@Gustry Gustry self-assigned this Feb 20, 2024
@Gustry
Copy link
Member

Gustry commented Feb 20, 2024

All files which can be downloaded from https://demo.lizmap.com are only for demonstration purpose and are not necessary for running the module.

When people visit the demo like PgRouting or another one, useless buttons for the purpose of the demo are hidden, and the main feature of the demo is already pre-activated (like for PgRouting, the panel is already shown, the tool already activated).

I thought I explained it in your the previous ticket 3liz/lizmap-pgrouting-module#48 (comment)

I will add JS comments in the code to explain it.

@gioman
Copy link
Author

gioman commented Feb 20, 2024

I thought I explained it in your the previous ticket #48 (comment)

@Gustry Sorry, I have read that in a different way, I was under the assumption that the script was mandatory.

@gioman gioman closed this as completed Feb 20, 2024
@Gustry Gustry reopened this Feb 20, 2024
@Gustry
Copy link
Member

Gustry commented Feb 20, 2024

No problem.
I want to add JS comments about that.

@Gustry Gustry transferred this issue from 3liz/lizmap-pgrouting-module Feb 20, 2024
@Gustry Gustry closed this as completed in 5087efa Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants