Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup children display - Add an option to use the component lizmap-features-table #4667

Open
mdouchin opened this issue Jul 31, 2024 · 5 comments
Labels
enhancement popup Sponsor or PR needed Either a PR or a sponsor is needed for this feature user interface
Milestone

Comments

@mdouchin
Copy link
Collaborator

mdouchin commented Jul 31, 2024

Is your feature request related to a problem? Please describe

In the context of a relation between a parent layer and a child layer, Lizmap allows at present to configure the parent popup to display the children popup underneath.

Since the recent addition of #4502 we should propose a way to use this component instead. It will look like :

image

Describe the solution you'd like

Either remove the present behaviour, or propose a new checkbox or a radio button to let the editor choose between showing the list of child popups or use the new compact table.

cc @rldhont @nboisteault @Gustry @mind84

@mdouchin mdouchin added enhancement Sponsor or PR needed Either a PR or a sponsor is needed for this feature labels Jul 31, 2024
@mdouchin mdouchin added this to the 3.9.0 milestone Jul 31, 2024
@Gustry Gustry added the popup label Jul 31, 2024
@mind84
Copy link
Contributor

mind84 commented Aug 12, 2024

@mdouchin,

I think this is an interesting addition.

  1. this works also when child popup is configured with Drag and Drop?
  2. In case there is multiple child relation, then a list for each child type is displayed?
  3. In many use cases editors choose Drag and Drop design and configure child relation in a separate tab to keep things organized. In present behaviour child are listed beneath the parent layer anyway. This new feature takes into account the child placement in the parent popup?

If this new feature could be improved with points above, I think that this new component could totally replace the actual behaviour. Otherwise IMHO is better to leave to editors the choiche

Thanks!

@Gustry
Copy link
Member

Gustry commented Aug 12, 2024

@mind84 Do you mean #3756 ?

@mind84
Copy link
Contributor

mind84 commented Aug 13, 2024

@mind84 Do you mean #3756 ?

Not directly, but yes

@mdouchin
Copy link
Collaborator Author

@mdouchin,

I think this is an interesting addition.

Indeed 👍 It's been a while I had this feature in mind. Happy to start shaping it.

1. this works also when child popup is configured with Drag and Drop?

At present, for 3.8, only the web component has been added. It is not yet used in LWC, but can be freely used by "power-users" in the parent popup (QGIS tooltip HTML configuration). I plan to integrate it further more in future 3.9

2. In case there is multiple child relation, then a list for each child type is displayed?

Nothing is done yet, but this will indeed be the desired behaviour when automatically used in child popup(s)

3. In many use cases editors choose Drag and Drop design and configure child relation in a separate tab to keep things organized. In present behaviour child are listed beneath the parent layer anyway. This new feature takes into account the child placement in the parent popup?

Not yet, I have in mind to fully respect the drag & drop designer for :

  • Automatic popup based on drag&drop form designer
  • Editing forms

If this new feature could be improved with points above, I think that this new component could totally replace the actual behaviour. Otherwise IMHO is better to leave to editors the choiche

Fully agree.
This is a work in progress and I hope to find time and/or resources to use this web component fully for 3.9

Thanks!

You are welcome, thanks a lot for sharing your thoughts

@mind84
Copy link
Contributor

mind84 commented Aug 13, 2024

@Gustry,

@mind84
Do you mean #3756 ?

Much more #4407

I have a PR ready for this but cannot be tested yet because of this behavior 3liz/qgis-lizmap-server-plugin#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement popup Sponsor or PR needed Either a PR or a sponsor is needed for this feature user interface
Projects
None yet
Development

No branches or pull requests

3 participants