Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: separator for min and max scale numbers #135

Open
effjot opened this issue Sep 5, 2022 · 4 comments
Open

Enhancement: separator for min and max scale numbers #135

effjot opened this issue Sep 5, 2022 · 4 comments

Comments

@effjot
Copy link
Contributor

effjot commented Sep 5, 2022

The format of the minimum and maximum scale fields is hard-coded as a slash in v_dataset, e.g. “1/1000”. Could we make this a configurable option? In German for example, scales are written with a colon (1:1000).

The selected locale is available in the query v_dataset, so we could add some code there, or we misuse the glossary table for a “scale number separator” item.

Edit: adding a thousands separator would be nice, too. I guess that this can be provided by the system locale / number formatting.

@effjot
Copy link
Contributor Author

effjot commented Jan 17, 2024

Do you have suggestions for this? For our internal application, I had added a glossary term scale_fraction which contains the fixed part (“1 :“ or “1 /”) and used in the v_dataset view.

@effjot
Copy link
Contributor Author

effjot commented Aug 26, 2024

Should I prepare a PR for this approach, or do you have something else in mind?

@Gustry
Copy link
Member

Gustry commented Aug 27, 2024

No sorry, I didn't get anything in mind.
I thought that PostgreSQL would be able to to give us the correct thousand separator.

For the scale separator, I just notice that QGIs uses : as well.

@effjot
Copy link
Contributor Author

effjot commented Aug 27, 2024

It might be that additional settings (lc_numeric maybe?) are necessary for thousands separator and decimal point/comma in PostgreSQL. I’m not that versed in the topic, though :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants