Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code checks to use clang-format-14 AND document which version of LLVM (and its tools) we are using for developing and formatting #491

Open
NikitaNikolaenko opened this issue Jul 22, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation Github Actions

Comments

@NikitaNikolaenko
Copy link
Contributor

The old clang-format-13 formats code like this:

[[nodiscard]] auto WaitForOneOfSignals(int(&&signums)[N]) {

clang-format-14 formats the same code like this:

[[nodiscard]] auto WaitForOneOfSignals(int (&&signums)[N]) {

This causes our code-check-style action to fail.

@CodingCanuck
Copy link
Contributor

Where are we using clang-format-14?

If/when we switch clang-format versions, we should do so everywhere (which I think just means also updating our GitHub codespaces for the respect repo: https://github.com/reboot-dev/respect/blob/411a39d3ce38f4222e5f3ce88896331dce6cd8fc/.devcontainer/Dockerfile#L59 )

@NikitaNikolaenko
Copy link
Contributor Author

Where are we using clang-format-14?

I locally use clang-format-14 since I'm using LLVM 14.

@NikitaNikolaenko NikitaNikolaenko added the documentation Improvements or additions to documentation label Jul 22, 2022
@NikitaNikolaenko NikitaNikolaenko changed the title Update code checks to use clang-format-14 Update code checks to use clang-format-14 AND document which version of LLVM (and its tools) we are using for developing and formatting Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Github Actions
Projects
None yet
Development

No branches or pull requests

2 participants