Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert db84d7311f353f7d3b1c943 #13

Open
EHJ-52n opened this issue Feb 26, 2018 · 5 comments
Open

Revert db84d7311f353f7d3b1c943 #13

EHJ-52n opened this issue Feb 26, 2018 · 5 comments
Assignees
Labels

Comments

@EHJ-52n
Copy link
Member

EHJ-52n commented Feb 26, 2018

I would like to have db84d73 reverted. You may add this to a profile and having this active per default is a real performance killer, e.g. the SOS project with many different remote repositories.

What do the others think?

The commit activated the download of all sources and javadoc jar of all dependencies of your project.

@ridoo
Copy link
Member

ridoo commented Feb 26, 2018

@EHJ-52n Have you tried to add options -DdownloadSources=true and -DdownloadJavadocs=true?

Anyway, I also think that downloading sources and javadoc is not neccessary for most cases. I think, either lazily loading sources and javadoc is a good alternative (most IDEs supports this). Or putting it in a profile is also a good option.

@autermann
Copy link
Member

Anyway, I also think that downloading sources and javadoc is not neccessary for most cases.

Well, in my opinion it is relevant for everyone doing development. End-users will for the most part download binary releases for which this is not relevant and the execution time for automated builds isn't that important (the SOS currently takes around 20 minutes and arctic-sea around 15 minutes on Travis and both cache their dependencies).

Nevertheless, I added a no-download profile in #14. Would that be sufficient?

@EHJ-52n
Copy link
Member Author

EHJ-52n commented Feb 27, 2018

I agree with you that it might be useful for everyone doing development, but what about the ones that would like to build from sources and run the software to just have the latest version!?

I would like to have the no-download profile as default.

@autermann
Copy link
Member

but what about the ones that would like to build from sources and run the software to just have the latest version!?

Those could download the latest snapshot?

@ridoo
Copy link
Member

ridoo commented Feb 28, 2018

IHMO it makes sense to get started as quickly as possible. To be honest, I do not know, how long downloading takes. But I don't think that every single dependency must be on the path with its sources.

However, I think this gets into individual tastes how to develop and when to get resources available when needed. I'd prefer the lazy alternative, though, I'd like to have all available once I am offline. So again: One could add this to her ~/.m2/settings.xml (choose your favorite flag value):

<settings>

   <!-- ... other settings here ... -->

    <profiles>
        <profile>
            <id>downloadSources</id>
            <properties>
                <downloadSources>true</downloadSources>
                <downloadJavadocs>true</downloadJavadocs>
            </properties>
        </profile>
    </profiles>

    <activeProfiles>
        <activeProfile>downloadSources</activeProfile>
    </activeProfiles>
</settings>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants