-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/psd 459 move etw inject node into this repo #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DianaStefan5Minds
wants to merge
23
commits into
develop
Choose a base branch
from
feature/PSD-459_Move_etw_inject_node_into_this_repo
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/psd 459 move etw inject node into this repo #93
DianaStefan5Minds
wants to merge
23
commits into
develop
from
feature/PSD-459_Move_etw_inject_node_into_this_repo
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Changelog v1.15.4 (16.07.2025) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v1.15.3 und v1.15.4](v1.15.3...v1.15.4). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v1.15.3](https://github.com/5minds/node-red-contrib-processcube/releases/tag/v1.15.3). ## Merged Pull Requests - #89 New version with updated client.ts (merged 16.07.2025) [skip ci]
# Changelog v1.15.5 (22.07.2025) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v1.15.4 und v1.15.5](v1.15.4...v1.15.5). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v1.15.4](https://github.com/5minds/node-red-contrib-processcube/releases/tag/v1.15.4). ## Merged Pull Requests - none [skip ci]
# Changelog v1.16.0 (25.07.2025) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v1.15.5 und v1.16.0](v1.15.5...v1.16.0). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v1.15.5](https://github.com/5minds/node-red-contrib-processcube/releases/tag/v1.15.5). ## Merged Pull Requests - #90 Make scope for processcube-engine-config configurable via string, sec… (merged 25.07.2025) [skip ci]
#92) ## Pull Request Overview This PR renames environment variables from `NODE_RED_*` to `NODERED_*` while maintaining backward compatibility, and fixes a memory leak by properly removing event hooks when the external task node is closed. **Key Changes:** - Adds support for new `NODERED_*` environment variable naming convention alongside existing `NODE_RED_*` variables - Implements proper cleanup of `preDeliver` and `postDeliver` hooks in the node's close handler - Updates Node-RED version from 4.0.8 to 4.1.1 ### Reviewed Changes Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | package.json | Version bump to 1.16.1 | | externaltask-input.js | Adds NODERED_* env var support, extracts hook callbacks to named functions, and removes hooks on node close | | Dockerfile | Updates base image to Node-RED 4.1.1-22 | | .processcube/nodered/.config.users.json | Updates config for Node-RED 4.1.1 with new view settings | | .processcube/nodered/.config.runtime.json | Adds telemetry disabled flag | | .processcube/nodered/.config.nodes.json | Updates version references to 4.1.1 and 1.16.1 | </details> --- 💡 <a href="/5minds/node-red-contrib-processcube/new/develop/.github?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
# Changelog v1.16.1 (27.10.2025) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v1.16.0 und v1.16.1](v1.16.0...v1.16.1). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v1.16.0](https://github.com/5minds/node-red-contrib-processcube/releases/tag/v1.16.0). ## Merged Pull Requests - #92 Rename vars NODE_RED -> NODERED; Disconnect hooks after Node is closed (merged 27.10.2025) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.