From 3fa61e4884aecc4abcabe825f93e94abb1a16731 Mon Sep 17 00:00:00 2001 From: Hannes Ljungberg Date: Sat, 22 Feb 2020 21:14:52 +0100 Subject: [PATCH 1/2] Filter out undefined classes --- src/cobertura.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cobertura.js b/src/cobertura.js index 73758f79..c276319d 100644 --- a/src/cobertura.js +++ b/src/cobertura.js @@ -13,6 +13,7 @@ async function processCoverage(path, options) { const { packages } = coverage; const classes = processPackages(packages); const files = classes + .filter(Boolean) .map(klass => { return { ...calculateRates(klass), From 42fe4880dfbe53c997f208c158324e4e1ebaeace Mon Sep 17 00:00:00 2001 From: Hannes Ljungberg Date: Sat, 22 Feb 2020 21:15:04 +0100 Subject: [PATCH 2/2] Use async readFile --- src/cobertura.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cobertura.js b/src/cobertura.js index c276319d..ff763128 100644 --- a/src/cobertura.js +++ b/src/cobertura.js @@ -1,11 +1,11 @@ -const fs = require("fs"); +const fs = require("fs").promises; const xml2js = require("xml2js"); const util = require("util"); const parseString = util.promisify(xml2js.parseString); async function processCoverage(path, options) { options = options || { skipCovered: false }; - const xml = fs.readFileSync(path, "utf-8"); + const xml = await fs.readFile(path, "utf-8"); const { coverage } = await parseString(xml, { explicitArray: false, mergeAttrs: true