Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor edk2 BuildCommand into slice of strings #518

Open
AtomicFS opened this issue Jan 23, 2025 · 0 comments · May be fixed by #519
Open

refactor edk2 BuildCommand into slice of strings #518

AtomicFS opened this issue Jan 23, 2025 · 0 comments · May be fixed by #519
Labels
feature New feature or request go Pull requests that update Go code low_priority Not very important quality_of_life Improve usage

Comments

@AtomicFS
Copy link
Collaborator

AtomicFS commented Jan 23, 2025

I think it would make it much nicer if the BuildCommand were a slice, the commands would then be much easier to read. Unfortunately this is a breaking change, but not that significant, people should be able to just change the JSON:

- "build_command": "source ./edksetup.sh; build -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -t ${GCC_TOOLCHAIN_VERSION}",
+ "build_command": ["source ./edksetup.sh; build -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b DEBUG -t ${GCC_TOOLCHAIN_VERSION}"],

That is if they do not want to take advantage of this new feature.

This new feature would also mean that we have to drop edk2's DefconfigPath.

@MDr164 when parsing JSON (or YAML #446), is the order of elements in JSON array preserved when fed into go's array/slice? My commons sense says it should be preserved, I just want to confirm.

@AtomicFS AtomicFS added feature New feature or request go Pull requests that update Go code quality_of_life Improve usage low_priority Not very important labels Jan 23, 2025
@AtomicFS AtomicFS linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request go Pull requests that update Go code low_priority Not very important quality_of_life Improve usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant