Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): change BuildCommand into slice #519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(cmd): change BuildCommand into slice #519

wants to merge 1 commit into from
+12 −38

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 23, 2025 •
edited
Loading

  • this is a breaking change
  • this should make the JSON configuration files much more readable for edk2
  • this change means we have to drop DefconfigPath for edk2

fixes #518

@AtomicFS AtomicFS requested a review from MDr164 as a code owner January 23, 2025 10:32
@AtomicFS AtomicFS enabled auto-merge January 23, 2025 10:32
@github-actions github-actions bot added feature New feature or request testing Testing related module/edk2 labels Jan 23, 2025
@AtomicFS
feat(cmd): change BuildCommand into slice
72b9ef7 
- this is a breaking change
- this should make the JSON configuration files much more readable for
  edk2
- this change means we have to drop DefconfigPath for edk2

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS force-pushed the feat/edk2-build-command-into-slice branch from 9558e59 to 72b9ef7 Compare January 23, 2025 10:50
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 23, 2025 •
edited
Loading

Failing because of

error:
input:
container.from resolve:
failed to resolve image ghcr.io/9elements/firmware-action/coreboot_4.19:main:
failed to resolve source metadata for ghcr.io/9elements/firmware-action/coreboot_4.19:main:
failed to copy:
httpReadSeeker:
failed open:
content at https://ghcr.io/v2/9elements/firmware-action/coreboot_4.19/manifests/sha256:b0beef78d1d9a2398e5909c6ccb92416eccb1aa7fc33e60ea442493b0de14d00 not found:
not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 Awaiting requested review from MDr164 MDr164 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request module/edk2 testing Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor edk2 BuildCommand into slice of strings
1 participant
@AtomicFS