Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for SAML Config #29

Open
strazto opened this issue May 13, 2022 · 2 comments
Open

Add UI for SAML Config #29

strazto opened this issue May 13, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@strazto
Copy link
Collaborator

strazto commented May 13, 2022

From #2 , but I'd like that to be closed and this opened in-lieu

@strazto strazto added the enhancement New feature or request label May 13, 2022
@9p4
Copy link
Owner

9p4 commented May 13, 2022

Will be done as soon as #27 is merged

@strazto
Copy link
Collaborator Author

strazto commented May 14, 2022

@9p4 Oh, are you implying you'll implement this?

If so, awesome! I don't really care about SAML personally, so I wasn't that keen to implement it, but as far as I know, the only difference in config fields are:

SAML Only:

samlEndpoint: string. The SAML endpoint.
samlClientId: string. The SAML client ID.
samlCertificate: string. The base64 encoded SAML certificate.

OIDC Only:

oidEndpoint: string. The OpenID endpoint. Must have a .well-known path available.
oidClientId: string. The OpenID client ID.
oidSecret: string. The OpenID secret.

roleClaim
oidScopes 

You may wish to refactor load/saveProvider functions into serializeShared, serializeSAML, serializeOIDC, and it'll probably make sense to group all of the the protocol specific options into the same section.
To reduce duplication, we can probably just hide whichever section doesn't apply to the current provider.

@strazto strazto added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants