Skip to content

Conversation

@penguian
Copy link
Collaborator

Closes #105

@penguian penguian self-assigned this Nov 17, 2025
@penguian penguian linked an issue Nov 17, 2025 that may be closed by this pull request
@penguian
Copy link
Collaborator Author

I have updated u-dq819/esm1p6_ancil and have used it to test the Python changes. The logs are in gadi:/scratch/tm70/pcl851/cylc-run/u-dq819.esm1p6_ancil/run20.

@penguian penguian marked this pull request as draft November 21, 2025 05:11
…n deposition (#104)

* Add a pre-industrial nitrogen example

* Rename and improve the nitrogen example

* Add scaffold code for nitrogen forcing

* Add forgotten args argument to save_cmip7_pi_nitrogen

* Add forgotten args argument to fix_coords

* Use arg.ancil_target_dirname

* Use esm_pi_nitrogen_save_dirpath

* Change the units and STASH code to match ACCESS-ESM1.6

* In the example notebook, change the units and STASH code to match ACCESS-ESM1.6

* Remove trailing whitespace

* Use STASH code m01s00i884
@penguian
Copy link
Collaborator Author

The change to relative imports affects all Python script files. Also, ruff format changed the order of the imports.

I have updated u-dq819/esm1p6_ancil and have used it to test the Python changes. The logs are in gadi:/scratch/tm70/pcl851/cylc-run/u-dq819.esm1p6_ancil/run22.

@penguian
Copy link
Collaborator Author

The pre-industrial nitrogen deposition ancillary is unchanged from the 18 November run:

$ mule-cumf --stashmaster 7.3 /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/pre-industrial/atmosphere/land/biogeochemistry/global.N96/2025.11.18/Ndep_1850_cmip7.anc /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/pre-industrial/atmosphere/land/biogeochemistry/global.N96/2025.11.21/Ndep_1850_cmip7.anc
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
* (CUMF-II) Module Information *
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

mule       : /g/data/xp65/public/apps/med_conda/envs/analysis3-25.09/lib/python3.11/site-packages/mule/__init__.py (version 2024.11.1)
um_utils   : /g/data/xp65/public/apps/med_conda/envs/analysis3-25.09/lib/python3.11/site-packages/um_utils/__init__.py (version 2024.11.1)
um_packing : /g/data/xp65/public/apps/med_conda/envs/analysis3-25.09/lib/python3.11/site-packages/um_packing/__init__.py (version 2024.11.1) (packing lib from SHUMlib: 2024111)


%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
* CUMF-II Comparison Report *
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

File 1: /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/pre-industrial/atmosphere/land/biogeochemistry/global.N96/2025.11.18/Ndep_1850_cmip7.anc
File 2: /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/pre-industrial/atmosphere/land/biogeochemistry/global.N96/2025.11.21/Ndep_1850_cmip7.anc
Files compare
  * 0 differences in fixed_length_header (with 7 ignored indices)
  * 0 field differences, of which 0 are in data

Compared 12/12 fields, with 12 matches

@penguian penguian marked this pull request as ready for review November 23, 2025 22:52
@penguian penguian requested a review from atteggiani November 23, 2025 22:53
@atteggiani
Copy link
Collaborator

Thank you @penguian.
Please read my comments in the issue #105.

@penguian penguian marked this pull request as draft November 24, 2025 21:39
@penguian
Copy link
Collaborator Author

Closing. See #105 which is also now closed.

@penguian penguian closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create and use a Python package called esm1p6_ancil

3 participants