Skip to content

Conversation

@dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented May 1, 2025

In order to successfully link libaccessom2 with pkg-config I had to list the datetime-fortran dependency under Requires, not Requires.private, in libaccessom2.pc. I can't say I understand why, but this seems to fix issues I was having with linking.

Also, with this PR we now set libdir from CMAKE_INSTALL_LIBDIR.

Also also, should OASIS packages be included in the Requires section? Things work for me without them included, but in my application I am also explicitly linking OASIS.

@dougiesquire dougiesquire self-assigned this May 1, 2025
@dougiesquire dougiesquire requested a review from harshula May 1, 2025 03:54
@harshula
Copy link

harshula commented May 1, 2025

https://people.freedesktop.org/~dbn/pkg-config-guide.html explains Requires.private.

@dougiesquire
Copy link
Collaborator Author

Yeah, I read that, but I don't think I understand why datetime-fortran needs to be exposed to applications in this case... Anyway I'll leave it up to you whether you're happy with this change.

@dougiesquire
Copy link
Collaborator Author

(Also, looks like someone needs to set up some branch protection rulesets on this repo)

@harshula
Copy link

harshula commented May 1, 2025

Hi @CodeGat ☝️

@CodeGat
Copy link
Member

CodeGat commented May 1, 2025

Branch protections updated :)

@dougiesquire
Copy link
Collaborator Author

@harshula would you be able to review?

@harshula
Copy link

harshula commented May 9, 2025

Hi @dougiesquire , I need to work out why Requires.private did not work and what we do in the futre. I should be able to get to it early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants