Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Consolidate fixtures from pruning and height profiles #843

Closed
ns-rse opened this issue May 14, 2024 · 1 comment
Closed

[tests] Consolidate fixtures from pruning and height profiles #843

ns-rse opened this issue May 14, 2024 · 1 comment
Assignees
@ns-rse
Labels
tests Issues pertaining to testing

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented May 14, 2024

Tests for pruning introduced a set of fixtures that are randomly generated skeletons which are then dilated to give corresponding heights (this gives us a "ground truth" as to what the skeleton that is being calculated by the methods was originally).

In developing tests for the height profiles I realised it would be useful to have similar examples to use in the tests. However, these were written in tests/tracing/conftest.py and aren't found when writing tests under tests/measure/test_height_profiles.py.

For now I've copied the relevant code into tests/conftest.py but after #748 is closed and before #800 is merged it would be useful to move tests/tracing/conftest.py fixtures to tests/conftest.py (this could be done on the ns-rse/818-tests-pruning branch).
@ns-rse ns-rse added the tests Issues pertaining to testing label May 14, 2024
@ns-rse ns-rse self-assigned this May 14, 2024
ns-rse added a commit that referenced this issue May 14, 2024
@ns-rse
tests: Moves dummy skeleton & heights fixtures to tests/conftest.py
a66d5ce 
Closes #843

Fixtures generated under `tests/tracing/conftest.py` are now generated under `tests/conftest.py` so that they are
available for other tests (at this point `tests/measure/test_height.py` that is in development).
@ns-rse ns-rse mentioned this issue May 14, 2024
Merged
@ns-rse
Copy link
Collaborator Author

ns-rse commented May 16, 2024

Closed by #844

@ns-rse ns-rse closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ns-rse ns-rse

Labels
tests Issues pertaining to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ns-rse