Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: asd available channels not logged #853

Closed
7 tasks done
MaxGamill-Sheffield opened this issue Jun 6, 2024 · 2 comments · Fixed by #855
Closed
7 tasks done

[Bug]: asd available channels not logged #853

MaxGamill-Sheffield opened this issue Jun 6, 2024 · 2 comments · Fixed by #855
Labels
bug Something isn't working

Comments

@MaxGamill-Sheffield
Copy link
Collaborator

Checklist

  • Re-run analysis with topostats process --core 1.
  • Describe the bug.
  • Include the configuration file.
  • Copy of the output.
  • The exact command that failed. This is what you typed at the command line, including any options.
  • TopoStats version, this is reported by topostats --version
  • Operating System and Python Version

Describe the bug

With the switch to AFMReader for asd i/o. The broad exception statement printing the warning for "Channel not found, skipping the image" is super-seeding the available channel message in AFMReader.asd

Copy of the output

screenshot_2024-06-06_at_10 36 58

Include the configuration file

N/A

To Reproduce

No response

TopoStats Version

Git main branch

Python Version

3.11

Operating System

MacOS M1/M2 (post-2021)

Python Packages

No response

@ns-rse
Copy link
Collaborator

ns-rse commented Jun 6, 2024

This hasn't been merged to main yet.

You can get information as to the version in the current Virtual Environment. Ideally a fresh pip install -e . should be done to ensure this is accurate.

❱ pip install -e .
❱ pip show topostats
Name: topostats
Version: 2.2.post1.dev190+g389fb1045
Summary: Automated Analysis for Atomic Force Microscopy Images of Biomolecules
Home-page: 
Author: 
Author-email: TopoStats Team <topostats@sheffield.ac.uk>, Alice Pyne <a.l.pyne@sheffield.ac.uk>, Sylvia Whittle <sylvia.whittle@sheffield.ac.uk>, Neil Shephard <n.shephard@sheffield.ac.uk>, Max Gamill <mcgamill1@sheffield.ac.uk>, Jean Du <mdu12@sheffield.ac.uk>
License: GNU Lesser GPLv3 only
Location: /home/neil/.virtualenvs/tmp-1b71451da46dd36/lib/python3.12/site-packages
Editable project location: /home/neil/work/git/hub/AFM-SPM/TopoStats
Requires: AFMReader, h5py, igor2, matplotlib, numpy, pandas, pyfiglet, pySPM, pyyaml, ruamel.yaml, schema, scikit-image, scipy, seaborn, snoop, tifffile, tqdm
Required-by: 

...and because we are dynamically setting version using setuptools_scm it appends the last tag with the post1.dev190+g389fb1045 which indicates the number of commits ahead and the hash of the last commit on that branch.

Or as per the issue template topostats --version reports this and it can be copy pasted.

❱ topostats --version
Installed version of TopoStats: 2.2.post1.dev190+g389fb1045

@MaxGamill-Sheffield
Copy link
Collaborator Author

Yep, just made a new PR for it. I forgot the keywords would close the accidental PR. Also because of testing on one branch ns-rse/851... then applying the changes to another main I thought the package list and commit version may have been more confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants