Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] : Bound aspect ratio between 0 and 1 #861

Closed
MaxGamill-Sheffield opened this issue Jun 12, 2024 · 0 comments · Fixed by #864
Closed

[feature] : Bound aspect ratio between 0 and 1 #861

MaxGamill-Sheffield opened this issue Jun 12, 2024 · 0 comments · Fixed by #864
Labels
enhancement New feature or request

Comments

@MaxGamill-Sheffield
Copy link
Collaborator

Is your feature request related to a problem?

Aspect ratio currently bounded between 1 -> inf, which feels like it holds less meaning than 0 -> 1.

Describe the solution you would like.

Change grainstats code:

# Enforce >= 1 aspect ratio
if aspect_ratio < 1.0:
    aspect_ratio = 1 / aspect_ratio

to

# Enforce <= 1 aspect ratio
if aspect_ratio > 1.0:
    aspect_ratio = 1 / aspect_ratio

Describe the alternatives you have considered.

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant