Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] : Ferret ratio metric #863

Open
MaxGamill-Sheffield opened this issue Jun 12, 2024 · 1 comment
Open

[feature] : Ferret ratio metric #863

MaxGamill-Sheffield opened this issue Jun 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MaxGamill-Sheffield
Copy link
Collaborator

Is your feature request related to a problem?

The current aspect ratio considers the cartesian bounding box of the grain, whereas a better descriptor might be the ratio of the min and max ferret diameters.

Describe the solution you would like.

Another metric calculating the min_ferret / max_ferret as a measure of compaction.

Describe the alternatives you have considered.

No response

Additional context

No response

@MaxGamill-Sheffield MaxGamill-Sheffield added the enhancement New feature or request label Jun 12, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented Sep 17, 2024

Could this be considered a duplicate of #860?

Both seem to be converging on the same solution so we could perhaps close #860 and address this one at some point in the future.

Off the top of my head min_feret and max_feret are already calculated as part of the summary statistics so the ratio is incredibly simple to calculate (a simple division).

NB - I could be wrong and this issue may be about 😉

A Ferret

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants