Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend tests of check_run_steps() to test nodestats_run and splining_run options #899

Closed
Tracked by #800
ns-rse opened this issue Sep 12, 2024 · 1 comment
Closed
Tracked by #800

Extend tests of check_run_steps() to test nodestats_run and splining_run options #899

ns-rse opened this issue Sep 12, 2024 · 1 comment
Assignees
@ns-rse
Labels
tests Issues pertaining to testing
Milestone
M3: dnaTracing Re...

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Sep 12, 2024 •
edited
Loading

With the splitting of configuration into separate stages for nodestats and splining we need to check that configuration options are consistent, i.e. that previous stages that are required are configured to run.

Currently that isn't implemented or tested is implemented but isn't tested (although I have setup the parameterisation of tests/test_processing.py::test_check_run_steps to do so because linting was failing).

The logic to make these checks and tests will need implementing and merging to maxgamill-sheffield/800-better-tracing.
@ns-rse ns-rse added the tests Issues pertaining to testing label Sep 12, 2024
@ns-rse ns-rse self-assigned this Sep 12, 2024
This was referenced Sep 12, 2024
Open
Open
@ns-rse ns-rse changed the title Extend check_run_steps() to test nodestats_run and splining_run Extend tests of check_run_steps() to test nodestats_run and splining_run options Sep 12, 2024
ns-rse added a commit that referenced this issue Sep 12, 2024
@ns-rse
chore: fix linting errors
ad285dc 
Fixes a bunch of linting errors, some notes left in place for tasks to be completed (e.g. see #899).
@ns-rse ns-rse mentioned this issue Sep 12, 2024
Merged
ns-rse added a commit that referenced this issue Sep 13, 2024
@ns-rse
chore: fix linting errors
7259eef 
Fixes a bunch of linting errors, some notes left in place for tasks to be completed (e.g. see #899).
ns-rse added a commit that referenced this issue Sep 13, 2024
@ns-rse
tests(processing): Improves logic and tests for check_run_steps()
45cc212 
Closes #899

Also updates `test_process_stages()` although this includes disabling a one set of parameters for the time being until I
work out what is now happening.
@ns-rse ns-rse mentioned this issue Sep 13, 2024
Merged
ns-rse added a commit that referenced this issue Sep 17, 2024
@ns-rse
chore: fix linting errors
4fa276c 
Fixes a bunch of linting errors, some notes left in place for tasks to be completed (e.g. see #899).
@ns-rse ns-rse closed this as completed Sep 17, 2024
@ns-rse
Copy link
Collaborator Author

ns-rse commented Sep 17, 2024

Closed by #903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ns-rse ns-rse

Labels
tests Issues pertaining to testing
Projects
None yet
Milestone
M3: dnaTracing Refactor and Features
Development

No branches or pull requests
1 participant
@ns-rse