Improvement regarding update

[maghuro]

An old issue (and the first one with the new team 😅)

• FlexQoS is installed. But Adaptive QoS is disabled.
• A wild update appears! Time to update!
• Because adaptive QoS is disabled, it is uninstalled when trying to update 😬

[dave14305]

The installation of an update uses the same code as a fresh installation. If Adaptive QoS is disabled, the installation aborts and cleans up after itself by deleting the downloaded file.

Why would someone want to keep FlexQoS installed and updated if Adaptive QoS is disabled? It's not a common scenario in my opinion.

[ExtremeFiretop]

Hi @maghuro and @dave14305

I attempted to recreate this bug report today, and while I am able to recreate the behaviour, I also need to better understand the use-case why this would be a concern. Why would you keep FlexQoS installed if you have Adaptive QoS disabled?

Here was the flow described:

1. Withdrew from the policy:

2. Confirmed Adaptive QoS was fully disabled:

3. Triggered an update, which did infact uninstall FlexQoS:

However before we can even consider addressing this, I would need to better understand why you would want to keep FlexQoS installed, and even update it, if it's not active or useful to you at that moment?

[ExtremeFiretop]

@maghuro can you describe in detail what you would expect it to do instead? Maybe that would help.
Would you expect the update process to enable the Adaptive QoS instead for example? Or prompt to give an option to do so? Maybe cancel the update until QoS is enabled?

[maghuro]

@maghuro can you describe in detail what you would expect it to do instead? Maybe that would help.
Would you expect the update process to enable the Adaptive QoS instead for example? Or prompt to give an option to do so? Maybe cancel the update until QoS is enabled?

Hello!
This isn't in fact a big deal.

I only activate adaptive QoS whenever I'm working from home (video calls, family using internet, sometimes torrenting). And I keep FlexQoS installed because of that.
I expect it, if disabled, to update and at the end ask "would you want to enable QoS?". If the user choose "no", the update proceeds and keeps disabled, but updated

[maghuro]

The installation of an update uses the same code as a fresh installation. If Adaptive QoS is disabled, the installation aborts and cleans up after itself by deleting the downloaded file.

Why would someone want to keep FlexQoS installed and updated if Adaptive QoS is disabled? It's not a common scenario in my opinion.

It isn't in fact a common scenario, and as I said, not a big deal.

I prefer you focus your efforts on big deals instead of this picky thing 💪🏻

[ExtremeFiretop]

@maghuro can you describe in detail what you would expect it to do instead? Maybe that would help.
Would you expect the update process to enable the Adaptive QoS instead for example? Or prompt to give an option to do so? Maybe cancel the update until QoS is enabled?

Hello! This isn't in fact a big deal.

I only activate adaptive QoS whenever I'm working from home (video calls, family using internet, sometimes torrenting). And I keep FlexQoS installed because of that. I expect it, if disabled, to update and at the end ask "would you want to enable QoS?". If the user choose "no", the update proceeds and keeps disabled, but updated

FlexQoS has no value if Adaptive QoS isn't enabled. It isn't meant to setup QoS from scratch. and I'm not sure of how feasible that is via shell, since you also need to opt into a policy agreement with ASUS/TrendMicro right? So the best we can do is cancel out of the update until QoS is enabled, or let the user decide when to uninstall as per the menu like usual.

I currently have a PR open for that change. Let me know if that's acceptable to close this issue.