From fbbc5c63bd5a4a5f1196146cf479f891606c02f9 Mon Sep 17 00:00:00 2001 From: ExtremeFiretop Date: Fri, 5 Sep 2025 19:59:42 -0400 Subject: [PATCH 1/3] Remove Cron Jobs on Uninstall Remove Cron Jobs on Uninstall --- flexqos.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/flexqos.sh b/flexqos.sh index 5504e9e..e29c98f 100644 --- a/flexqos.sh +++ b/flexqos.sh @@ -12,7 +12,7 @@ # Contributors: @maghuro # shellcheck disable=SC1090,SC1091,SC2039,SC2154,SC3043 # amtm NoMD5check -version=1.4.9 +version=1.4.10 release=2025-08-04 # Forked from FreshJR_QOS v8.8, written by FreshJR07 https://github.com/FreshJR07/FreshJR_QOS # License @@ -1940,6 +1940,8 @@ uninstall() { rm -f "/opt/bin/${SCRIPTNAME}" 2>/dev/null printf "Removing delayed cron job...\n" cru d "${SCRIPTNAME}_5min" 2>/dev/null + printf "Removing QoS schedule cron jobs...\n" + _qs_clear_jobs remove_webui printf "Removing %s settings...\n" "${SCRIPTNAME_DISPLAY}" if [ "${force}" = "force" ] || [ "${force}" = "-f" ]; then From d7d116ba987baa97f9cdf5223665ffa5657ec9d7 Mon Sep 17 00:00:00 2001 From: ExtremeFiretop Date: Fri, 5 Sep 2025 20:08:30 -0400 Subject: [PATCH 2/3] Update Changelog Update Changelog --- Changelog.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog.txt b/Changelog.txt index 7c738cf..5308093 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,3 +1,6 @@ +v1.4.10 (08-Sep-2025) + - FIXED: Adressed missing cleanup for any cron job schedules when uninstalling. + v1.4.9 (04-Sep-2025) - NEW: Includes Flexible/Dynamic Scheduling of the QoS system on ASUS routers. As requested here: https://www.snbforums.com/threads/flexqos-1-4-8-flexible-qos-enhancement-script-for-adaptive-qos.94976/post-964632 From ce9cc15dd4993b0e451a586d96a470f9b18985bc Mon Sep 17 00:00:00 2001 From: ExtremeFiretop Date: Sat, 6 Sep 2025 07:24:31 -0400 Subject: [PATCH 3/3] Allow Backup of New Schedules Allow Backup of New Schedules --- Changelog.txt | 1 + flexqos.sh | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Changelog.txt b/Changelog.txt index 5308093..645590d 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,5 +1,6 @@ v1.4.10 (08-Sep-2025) - FIXED: Adressed missing cleanup for any cron job schedules when uninstalling. + - FIXED: Missing the ability to backup the new QoS schedules. v1.4.9 (04-Sep-2025) - NEW: Includes Flexible/Dynamic Scheduling of the QoS system on ASUS routers. As requested here: https://www.snbforums.com/threads/flexqos-1-4-8-flexible-qos-enhancement-script-for-adaptive-qos.94976/post-964632 diff --git a/flexqos.sh b/flexqos.sh index e29c98f..6b7f69e 100644 --- a/flexqos.sh +++ b/flexqos.sh @@ -976,6 +976,7 @@ backup() { [ -n "$(am_settings_get "${SCRIPTNAME}"_appdb)" ] && printf "am_settings_set %s_appdb \"%s\"\n" "${SCRIPTNAME}" "$(am_settings_get "${SCRIPTNAME}"_appdb)" [ -n "$(am_settings_get "${SCRIPTNAME}"_bwrates)" ] && printf "am_settings_set %s_bwrates \"%s\"\n" "${SCRIPTNAME}" "$(am_settings_get "${SCRIPTNAME}"_bwrates)" [ -n "$(am_settings_get "${SCRIPTNAME}"_qdisc)" ] && printf "am_settings_set %s_qdisc \"%s\"\n" "${SCRIPTNAME}" "$(am_settings_get "${SCRIPTNAME}"_qdisc)" + [ -n "$(am_settings_get "${SCRIPTNAME}"_schedule)" ] && printf "am_settings_set %s_schedule \"%s\"\n" "${SCRIPTNAME}" "$(am_settings_get "${SCRIPTNAME}"_schedule)" } > "${ADDON_DIR}/restore_${SCRIPTNAME}_settings.sh" if /bin/grep -q "${SCRIPTNAME}_" "${ADDON_DIR}/restore_${SCRIPTNAME}_settings.sh"; then Green "Backup done to ${ADDON_DIR}/restore_${SCRIPTNAME}_settings.sh" @@ -991,6 +992,7 @@ backup() { read -r yn if [ "${yn}" = "1" ]; then sh "${ADDON_DIR}/restore_${SCRIPTNAME}_settings.sh" + qos_schedule_apply_from_config Green "Backup restored!" needrestart=1 else