Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved franchise voiceovers are not displayed #103

Closed
AN0NCER opened this issue May 10, 2024 · 2 comments
Closed

Saved franchise voiceovers are not displayed #103

AN0NCER opened this issue May 10, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@AN0NCER
Copy link
Owner

AN0NCER commented May 10, 2024

En
When adding voiceovers to favorites, everything is fine. But when I try to watch it from another franchise, I need to mark it again.

Ru
При добавлении озвучки в избранное все в порядке. Но когда я пытаюсь посмотреть его из другой франшизы, мне нужно отметить его снова.

@AN0NCER AN0NCER added the bug Something isn't working label May 10, 2024
@AN0NCER AN0NCER self-assigned this May 10, 2024
AN0NCER added a commit that referenced this issue May 10, 2024
AN0NCER added a commit that referenced this issue May 10, 2024
@AN0NCER
Copy link
Owner Author

AN0NCER commented May 10, 2024

En
The bug has been fixed. But we need to remake the system for selecting voiceovers into favorites. Because now you can add voice acting to your favorites, but you won’t be able to remove it from the same anime in which the choice was made.

Ru
Баг то исправил. Но надо переделать систему выбора озвучки в избраное. Потому что сейчас можно добавить озвучку в избранное но удалить его не получиться не стого аниме в котором был сделан выбор. Нужно бы пересмотреть следующие файлы

  • watch/mod_translation.js
  • watch/mod_player.js 18

@AN0NCER AN0NCER pinned this issue May 10, 2024
@AN0NCER AN0NCER added question Further information is requested and removed bug Something isn't working labels Jul 10, 2024
@AN0NCER
Copy link
Owner Author

AN0NCER commented Oct 2, 2024

En
Finally got to those files. Already rewrote the file mod_player.js and it became much more convenient so I think to make other changes will not be difficult.

Ru
Наконец-то добрался до этих файлов. Уже переписал файл mod_player.js и он стал намного удобнее, так что думаю внести другие изменения не составит труда.

AN0NCER added a commit that referenced this issue Oct 3, 2024
@AN0NCER AN0NCER closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant