Clarify registration descriptor usage #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording makes it believe it should be in the (program-wide) PMT descriptor loop, whereas it should be within the elementary-stream descriptor loop
cconcolato
reviewed
Feb 24, 2023
| @@ -74,7 +74,7 @@ <h1>Identifying AV1 streams in MPEG-2 TS</h1> | |||
|
|
|||
| ## AV1 registration descriptor | |||
|
|
|||
| The presence of a Registration Descriptor, as defined in [[!MPEG-2 TS]], is mandatory with the *format_identifier* field set to 'AV01' (A-V-0-1). The Registration Descriptor shall be the first in the PMT loop and included before the AV1 video descriptor. | |||
| The presence of a Registration Descriptor, as defined in [[!MPEG-2 TS]], is mandatory with the *format_identifier* field set to 'AV01' (A-V-0-1). The Registration Descriptor shall be conveyed in the descriptor loop for the respective elementary stream entry in the program map table, and included before the AV1 video descriptor. | |||
There was a problem hiding this comment.
I'm not sure about the "respective ES entry".
Should we say:
When an elementary stream entry in the PMT contains an AV1 video descriptor, it shall have a Registration Descriptor and that RD shall be before the AV1 video descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording makes it believe it should be in the (program-wide) PMT descriptor loop, whereas it should be within the elementary-stream descriptor loop
Fixes #41
Preview | Diff