Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for InfluxDB2 #22

Open
lujop opened this issue Dec 26, 2019 · 5 comments
Open

Support for InfluxDB2 #22

lujop opened this issue Dec 26, 2019 · 5 comments

Comments

@lujop
Copy link

lujop commented Dec 26, 2019

Is there any plans to support InfluxDB 2.0?
If I had time to contribute a PR would it be accepted?

@aveuiller
Copy link
Contributor

Hello,

unfortunately there isn't any active development on this project, however PRs are very welcome!

Adding the support for influx 2.0 should be as easy as adding a value to the version enumerate: https://github.com/APISENSE/embed-influxDB/blob/develop/src/main/java/io/apisense/embed/influx/configuration/InfluxVersion.java

However, I can see that the version 2.0.0 is in alpha, so if you contribute be wary of the version you enter. The enum entry name being used for generating the download link :)

@lujop
Copy link
Author

lujop commented Dec 28, 2019

I started by defining Version 2 and it works correctly if you don't use a configuration file.
It seems that InfluxDB2 doesn't support a configuration file by now.

I have looked at it quickly and it seems that to support configuration without configuration file will require at least a configuration abstraction and API changes because currently configuration is tied to a file.

If I had some time I will look with more detail if I found a way to mantain code clean and doesn't make a lot of breaking changes. Also I will ask in some influxdb forum is the lack of configuration file for version 2 is temporal or not

Current work at branch https://github.com/lujop/embed-influxDB/tree/issue_22 commit lujop@fa51ab2

@aveuiller
Copy link
Contributor

Hello,

Sorry for the delay!

Your branch looks good so far. As for not using any configuration file, I did not take this use case into account during the integration but that may be feasible to use some concepts from the upstream library, considering that it exists a command-line post-processor interface: https://github.com/flapdoodle-oss/de.flapdoodle.embed.process/blob/master/src/main/java/de/flapdoodle/embed/process/runtime/CommandLinePostProcessor.java#L31:18

I will try to find some time to take a deeper look into it, don't hesitate if you want to go further and propose an integration of configuration through both files and command line. :)

@mjacoby
Copy link

mjacoby commented Nov 17, 2022

Any update on the integration of InfluxDB 2.x? It's been a while since the last activity and v2.x is now stable for some time

@aveuiller
Copy link
Contributor

Hello,

I didn't take the time to check that until then. I just deployed a v1.3.1 with the latest version 2.5.1 integrated, along with a way to use custom revisions using the class CustomInfluxVersion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants