Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the is single method incorrect for next gui slot? #171

Open
Fusezion opened this issue Oct 11, 2023 · 3 comments
Open

Is the is single method incorrect for next gui slot? #171

Fusezion opened this issue Oct 11, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Oct 11, 2023

Description

I ran into an error for using set {_slot} to next gui slot saying a single variable can't be set to more than one object, after looking at the code I've come to realize that the comparison for isSingle might be incorrect.

Code in Question

@Override
public boolean isSingle() {
return guis != null && guis.isSingle();
}

My View
the condition guis != null && guis.isSingle() should be guis == null || guis.isSignle(), since the system should output true if it's null otherwise return what the expression says it is.

Note

I'm aware this should have been a bug report, but didn't wanna log into my server to get the version information or screenshots

@Fusezion Fusezion added the question Further information is requested label Oct 11, 2023
@LohsMC
Copy link

LohsMC commented Nov 25, 2023

Is that why I keep getting this message when sending the next gui slot?
image

@Fusezion
Copy link
Contributor Author

No

@APickledWalrus
Copy link
Owner

sounds like a bug :) thought i replied to this already but it is on my radar

@APickledWalrus APickledWalrus added bug Something isn't working good first issue Good for newcomers and removed question Further information is requested labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants