Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with other addons and skript #175

Open
Fusezion opened this issue Jan 9, 2024 · 3 comments
Open

Conflict with other addons and skript #175

Fusezion opened this issue Jan 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Jan 9, 2024

Description

Other addons using two expressions like X %string% and X id of %string% will conflict with ExprIDOfGUI when using a variable due to base syntax being id of %gui%

Steps to Reproduce

Have two expressions one like blah id of %something% and another like blah %string%
use a variable for the first expression like blah id of {-something}
and be parsed as blah %string%

Expected Behavior

Other expressions using blah id of x not be overridden by id[entifier] of %gui% expression when there's a secondary expression like blah %string%

Errors / Screenshots

image

Server Information

image

Additional Context

While this is mostly due to poor conventions the expressions used should of been unique enough to be separated the issue lies in ExprIDOfGUI not having a something to make it stand out like gui id of {-gui} issue even if unrelated needs fixed as this would conflict with just about anything using blah %string%

A straight way to say this is recipe %string% and recipe id of %string% are conflicting with id of %gui% when I do code like

set {_recipe} to recipe "blah:blah"
broadcast recipe id of {_recipe}

this is parsed as recipe id of GUI

@Fusezion Fusezion added the bug Something isn't working label Jan 9, 2024
@APickledWalrus
Copy link
Owner

I'm not sure there is much i can do here (other than just forcing the usage of gui as a keyword)

@Fusezion
Copy link
Contributor Author

I'm not sure there is much i can do here (other than just forcing the usage of gui as a keyword)

that's about what I expected, for something generic like this I figured that's the best usage to prevent any future conflicts.

@Fusezion
Copy link
Contributor Author

This also applies to shape of %gui% conflicts when using variables for stuff like recipe shape of {-blah}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants