[#946] Fix calculation in spacecraftLocation

Author: Mark2000

docs/source/Support/bskReleaseNotes.rst

@@ -32,6 +32,7 @@ Version |release|
   using only a header-defaulted destructor with ``= default;`` syntax.
 - Fixed issue where reaction wheels with unlimited torque (``useMaxTorque=False``) would end simulation prematurely
 - Added safety mechanism to limit excessive wheel acceleration and provide warning messages
+- Fix a bug in the :ref:`SpacecraftLocation` module.
 
 
 Version  2.6.0  (Feb. 21, 2025)

src/simulation/environment/spacecraftLocation/spacecraftLocation.cpp

@@ -183,12 +183,13 @@ void SpacecraftLocation::computeAccess()
         // compute point of closest approach
         double param;               // line scaling parameter
         param = - r_LP_P.dot(r_SL_P)/r_SL_P.dot(r_SL_P);
-        Eigen::Vector3d rClose = r_LP_P + param * r_SL_P;
 
         // check for out of bounds condition.
         param = std::min(param, 1.0); // If param > 1, the closest point on segment is the other satellite
         param = std::max(param, 0.0); // If param < 0, the closest point on segment is the primary satellite
 
+        Eigen::Vector3d rClose = r_LP_P + param * r_SL_P;
+
         // determine access output message
         this->accessMsgBuffer.at(c) = this->accessOutMsgs.at(c)->zeroMsgPayload;
         if (rClose.norm() > this->rEquator) {