From aa56af1827f9aa44dee50e5b872f3e6122387019 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 19:39:11 +0800 Subject: [PATCH 01/15] Fix links in UG --- docs/UserGuide.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index ebed5559dd6..d0a80c401d2 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -22,7 +22,7 @@ title: User Guide _(For users who just want to see the table of contents, click [here](#table-of-contents).)_ To begin using this guide, ensure you have [installed Jobby](#installation). - Once this is done, go to the [tutorial](#jobby-tutorial--for-new-users-) section to get started on the basic features of Jobby. + Once this is done, go to the [tutorial](#jobby-tutorial-for-new-users) section to get started on the basic features of Jobby. When you become more familiar with the basic features, you can move on to understand [how Jobby's commands are structured and how to use autocomplete to your advantage](#using-jobby). @@ -105,10 +105,10 @@ Jobby comes equipped with a user interface that provides visual feedback to you. | Component | Description | |---------------------|------------------------------------------------------------------------------------------------------------| -| Command Box | You will enter your [commands](#glossary) along with its input here. | +| Command Box | You will enter your commands along with its input here. | | Result Display | Displays the results of your commands.
Any error messages will also be displayed here. | | Contact Details | Contains information related to the [contact](#glossary) like name, phone number, email etc. | -| Application Details | Contains information related to the [internship application](#glossary) details like status, deadline etc. | +| Application Details | Contains information related to the internship application details like status, deadline etc. | -------------------------------------------------------------------------------------------------------------------- @@ -402,7 +402,7 @@ edit INDEX/ID [--name NAME] [--id ID] [--phone PHONE] [--email EMAIL] [--url URL | Command | Reason | |-----------------------------------------|-------------------------------------------------------------------------------------| -| `edit google --phone 8124!@#$` | `--phone` has an [invalid parameter](appendix-a--acceptable-values-for-parameters) | +| `edit google --phone 8124!@#$` | `--phone` has an [invalid parameter](#appendix-a-acceptable-values-for-parameters) | ### Applying to organizations - `apply`
Job Application
@@ -548,7 +548,7 @@ find KEYWORD/ID... | Command | Reason | |-------------------|-----------------------------------------------------------------------------------------------------| -| `find jo` | Finds Contacts and Applications whose **KEYWORD/ID** contains the [substring](#Glossary) "jo". | +| `find jo` | Finds Contacts and Applications whose **KEYWORD/ID** contains the [substring](#glossary) "jo". | | `find 1231` | Finds Contacts and Applications whose **KEYWORD/ID** contains the substring "1231". | | `find alex david` | Finds Contacts and Applications whose **KEYWORD/ID** contains the substring "alex" or "david". | From 372ecfb3cbfa373e0a8f204c0c6172a17bf3de99 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 19:57:14 +0800 Subject: [PATCH 02/15] Add description and tips for each command --- docs/UserGuide.md | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index d0a80c401d2..a6896e598c7 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -322,8 +322,10 @@ The `add` command allows you to create contacts to track details about the organ ```sh add --org --name NAME [--id ID] [--phone NUMBER] [--email EMAIL] [--url URL] [--address ADDRESS] [--tag TAG]... ``` +Adds an organization contact with the details given to the command. * If an `ID` is not specified, one will be automatically generated. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples @@ -350,10 +352,11 @@ add --org --name NAME [--id ID] [--phone NUMBER] [--email EMAIL] [--url URL] [-- ```sh add --rec --name NAME [-id ID] [--oid ORG_ID] [--phone NUMBER] [--email EMAIL] [--url URL] [--address ADDRESS] [--tag TAG]... ``` +Adds a recruiter contact with the details given to the command. -* When adding in parameters, be aware of the [accepted parameters](#appendix-a-acceptable-values-for-parameters). * If an `ID` is not specified, one will be automatically generated. * To link a Recruiter to an Organization in the contacts list, make sure you include `--oid` and pass in the `ID` of the Organization you want to link to. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Sample demonstration * If you execute the command: `add --rec --name Ryan Koh --oid job_seeker_plus`, you should see a new Recruiter being added to the bottom of the contacts list. @@ -389,6 +392,9 @@ add --rec --name NAME [-id ID] [--oid ORG_ID] [--phone NUMBER] [--email EMAIL] [ ```sh edit INDEX/ID [--name NAME] [--id ID] [--phone PHONE] [--email EMAIL] [--url URL] [--address ADDRESS] [--tag TAG]... ``` +Edits the given contact according to the parameters given. +* You can supply more than one parameter to change multiple details of a contact in one command. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples @@ -414,6 +420,8 @@ edit INDEX/ID [--name NAME] [--id ID] [--phone PHONE] [--email EMAIL] [--url URL ```sh apply INDEX/ID --title TITLE [--description DESCRIPTION] [--by DEADLINE: DD-MM-YYYY] [--stage APPLICATION STAGE: resume | online assessment | interview] [--status STATUS: pending | offered | accepted | turned down] ``` +Applies to the given organization by creating a job application associated with it. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples @@ -441,6 +449,10 @@ apply INDEX/ID --title TITLE [--description DESCRIPTION] [--by DEADLINE: DD-MM-Y edit --application INDEX [--title TITLE] [--description DESCRIPTION] [--by DEADLINE] [--status STATUS] [--stage STAGE] ``` +Edits the given job application according to the parameters given. +* You can supply more than one parameter to change multiple details of an application in one command. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). + ##### Valid examples | Command | Reason | @@ -470,7 +482,9 @@ edit --application INDEX [--title TITLE] [--description DESCRIPTION] [--by DEADL ```sh delete INDEX/ID [--recursive] ``` +Deletes the contact at the given `INDEX` or `ID`. * `--recursive` flag deletes the associated recruiter contacts and internship applications if the contact to delete is an organization. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples @@ -494,6 +508,8 @@ delete INDEX/ID [--recursive] ```sh delete --application INDEX ``` +Deletes the job application at the given `INDEX`. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples @@ -542,7 +558,9 @@ Lists all contacts. If you provide a parameter, the contacts listed will be only ```sh find KEYWORD/ID... ``` -* This will return any Organization or Recruiter that contains the given keywords. + +Finds and lists the contacts containing the given `KEYWORD` or contact with the given `ID`. +* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples From 6a986acb3cb9b2f7e97f90511d9cacd267fbdbde Mon Sep 17 00:00:00 2001 From: "LAPTOP-NQHH6Q7K\\Juanpa" Date: Mon, 13 Nov 2023 20:59:09 +0800 Subject: [PATCH 03/15] Add clear, exit, and help to UG --- docs/UserGuide.md | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index b7113877811..530605008b7 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -669,6 +669,43 @@ Reminds you of upcoming deadlines for job applications. | `remind` | No urgency level specified. | +### Viewing help - `help` + +##### Format +```sh +help +``` + +Shows a message explaining how to access the help page. + +![Help Message](images/helpMessage.png) + + +### Clearing all data - `clear` +
Organization Recruiter Job Application
+ +:warning: The deletion of all data is permanent and there is no way to undo it. + +:trophy: How to clear all contacts and job applications in Jobby Intermediate + +##### Format +```sh +clear +``` + +Clears all data from your Contacts and Job Applications. + + +### Exiting the program - `exit` + +##### Format +```sh +exit +``` + +Exits the program. + + -------------------------------------------------------------------------------------------------------------------- ## Command Summary From 6d01ea06728d5c9360bfb018320df6c819e4823b Mon Sep 17 00:00:00 2001 From: "LAPTOP-NQHH6Q7K\\Juanpa" Date: Mon, 13 Nov 2023 21:02:37 +0800 Subject: [PATCH 04/15] Add suitable tags to help and exit --- docs/UserGuide.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 530605008b7..bbd79d4955b 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -671,6 +671,8 @@ Reminds you of upcoming deadlines for job applications. ### Viewing help - `help` +Beginner + ##### Format ```sh help @@ -698,6 +700,8 @@ Clears all data from your Contacts an ### Exiting the program - `exit` +Beginner + ##### Format ```sh exit From 7dee5f67863b1ffa4781caedfa8e20cdc2de3ef3 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:06:38 +0800 Subject: [PATCH 05/15] Update find command for UG --- docs/UserGuide.md | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index a6896e598c7..d5da4124765 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -552,34 +552,33 @@ Lists all contacts. If you provide a parameter, the contacts listed will be only ### Searching contacts - `find`
Organization Recruiter
-:trophy: How to find organizations and recruiters by name or id Beginner +:trophy: How to find organizations and recruiters by keyword Beginner ##### Format ```sh -find KEYWORD/ID... +find KEYWORD... ``` -Finds and lists the contacts containing the given `KEYWORD` or contact with the given `ID`. -* If you wish to know more about the requirements for each parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). +Finds the contacts whose `NAME` or `ID` contains the given `KEYWORD`. +* You can supply multiple keywords as long as they are separated by [whitespace](#glossary). +* If you wish to know more about the requirements for the parameter, check out the [given appendix](#appendix-a-acceptable-values-for-parameters). ##### Valid examples | Command | Reason | |-------------------|-----------------------------------------------------------------------------------------------------| -| `find jo` | Finds Contacts and Applications whose **KEYWORD/ID** contains the [substring](#glossary) "jo". | -| `find 1231` | Finds Contacts and Applications whose **KEYWORD/ID** contains the substring "1231". | -| `find alex david` | Finds Contacts and Applications whose **KEYWORD/ID** contains the substring "alex" or "david". | +| `find jo` | Finds contacts whose `NAME` or `ID` contains the [substring](#glossary) "jo". | +| `find 1231` | Finds contacts whose `NAME` or `ID` contains the substring "1231". | +| `find alex david` | Finds contacts whose `NAME` or `ID` contains the substring "alex" or "david". | ##### Rules Intermediate -* The search is case-insensitive. e.g `hans` will match `Hans` -* The order of the keywords does not matter. e.g. `Hans Bo` will match `Bo Hans` +* The search is case-insensitive. e.g `hans` will match `Hans` and `1231` will match `id_1231`. +* The order of the keywords does not matter. e.g. `Hans Bo` will match `Bo Hans`. * You can match partial keywords. e.g. searching for `ha` will match with `hamburger`. -* Partial IDs can match the entire ID. e.g. searching for `1234` will match with `id_12345`. -* Persons matching at least one keyword will be returned (i.e. `OR` search) - e.g. `Hans Bo` will return `Hans Gruber`, `Bo Yang` -* Can match with multiple ids `12345 id_51231` will match with `id_12345` and `id_51231` +* Contacts matching at least one keyword will be returned (i.e. `OR` search) + e.g. `Hans Bo` will return `Hans Gruber`, `Bo Yang`. ### Sorting data - `sort` From 1c9c541c0c194d86f890f2068a5cef6725e02082 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:12:24 +0800 Subject: [PATCH 06/15] Add preamble for delete command --- docs/UserGuide.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 1cc3d3fe5ab..145d317788c 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -476,6 +476,8 @@ Edits the given job application according to the parameters given. :warning: The deletion of data is permanent and there is no way to undo it. +The `delete` command allows you to delete contacts and job applications if they are no longer relevant. To learn more about deleting a contact or application, check out the sections below. + #### Deleting contacts - `delete` :trophy: How to delete contacts and job applications in Jobby Intermediate From 7e4213a4165428745559bda4f902a4bf9469d221 Mon Sep 17 00:00:00 2001 From: "LAPTOP-NQHH6Q7K\\Juanpa" Date: Mon, 13 Nov 2023 21:13:03 +0800 Subject: [PATCH 07/15] Add known issues to UG --- docs/UserGuide.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index bbd79d4955b..988ab7eae61 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -784,6 +784,10 @@ Exits the program. -------------------------------------------------------------------------------------------------------------------- -## Issues +## Known Issues -(Where to report issues and what bugs currently exist) +1. **When using multiple screens**, if you move the application to a secondary screen, and later switch to using only the primary screen, the GUI will open off-screen. The remedy is to delete the _preferences.json_ file created by the application before running the application again. + +2. **When requesting to sort applications after a call to `list --rec`**, the command will succeed but display nothing, since no organizations are currently listed, and so no linked applications will display. The remedy is to call `list` before sorting applications and calling the sort command once more. + +3. Parameter names use either the `-` or `--` prefix, but **all commands as of the current version only use the `--` prefix.** The `-` prefix is currently unused, but in future updates it may become relevant. From 3942ac5f270324f8e4242e71ca9750e7a7c2f842 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:18:35 +0800 Subject: [PATCH 08/15] Tidy up markdown for glossary and appendix --- docs/UserGuide.md | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 145d317788c..00c4987b737 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -729,8 +729,8 @@ Reminds you of upcoming deadlines for job applications. ## Glossary -| Term | Definition | -|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| Term | Definition | +|------|------------| | **Top Level Domain** | A Top Level Domain (TLD) is the part of the website address where it comes after the last dot (i.e. ".com", ".org", ".net") and before the first slash. (E.g. www.example.**com**/path). | | **Whitespace** | In the context of this application, a whitespace is any number of spaces or tabs that is in the input. | | **Contact** | A contact in Jobby is can be an **organization** or a **recruiter**. | @@ -741,23 +741,23 @@ Reminds you of upcoming deadlines for job applications. ### Appendix A: Acceptable values for parameters -| Parameter | Used by | Requirements | Examples | -|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------| -| `INDEX` | [`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application)
[`delete`](#deleting-contacts---delete)
[`delete --application`](#deleting-job-applications---delete---application) | A valid index can accept any positive integer up to the number of items in the contact or job application list where applicable. | `1`
`10` | -| `NAME` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid name can accept any non-empty value. | `Ryan Koh`
`小明` | -| `ID` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`delete`](#deleting-contacts---delete) | A valid ID has to start with a letter.

It can consist of alphanumeric and basic symbols (i.e. `a-z`, `A-Z`, `0-9`, `-`, `_`) | `woogle123`
`ryan_soc-rec` | -| `NUMBER` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid phone number can consist of only numbers with no whitespace.

It must be at least 3 digits. | `999`
`91824137` | -| `EMAIL` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid email should be in the form of `local-part@domain` where the `local-part` and `domain` must be separated by a single **@**.

The `local-part` can consist of any character except whitespace.

The `domain` name can comprise of one or more labels separated by periods, and each label can include any character except whitespace. The last `domain` label must be a minimum of two characters long. | `ryankoh@nus`
`ryan-koh@nus.edu.sg` | -| `URL` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid url should include a part in the form of `domain.tld` where the `domain` and the `tld` (top level domain) must be separated by a period. | `example.com`
`example.more.com`
`https://example.com`
`example.com/more` | -| `ADDRESS` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid address can accept any non-empty value.

For a contact, it designates its physical address. | `21 Lower Kent Ridge Rd` | -| `TAG` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid tag can consist of only alphanumeric characters. | `internship`
`network`
`parttime`
`jobPortal` | -| `ORG_ID` | [`add --rec`](#adding-recruiters---add---rec) | A valid organization ID is subject to the same requirements as the ID parameter.

It must belong to an Organization contact in the address book. | `woogle123`
`meta_sg-1` | -| `TITLE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid title can accept multiple words separated with spaces, as long as the characters are alphanumeric. | `Software Engineer`
`Level 3 Engineer` | -| `DESCRIPTION` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid description can accept any non-empty value. | `Senior Role`
`Hourly rate: $25` | -| `DEADLINE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid deadline should be a date in the form of `DD-MM-YYYY`.

The day (`DD`) and month (`MM`) can be either single or double digits. | `09-02-2022`
`9-2-2022`
`19-11-2022` | -| `STAGE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid job application stage can accept only one of the three values: `resume`, `online assessment`, `interview`.

The values are ranked in the order shown. | `resume`
`online assessment`
`interview` | -| `STATUS` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid job application status can accept only one of the four values: `pending`, `offered`, `accepted`, `turned down`.

The values are ranked in the order shown. | `pending`
`offered`
`accepted`
`turned down` | -| `KEYWORD` | [`find`](#searching-contacts---find) | A valid keyword is a single word that can accept any non-empty value. | `software`
`Ryan` | +| Parameter | Used by | Requirements | Examples | +|-----------|---------|--------------|----------| +| `INDEX` | [`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application)
[`delete`](#deleting-contacts---delete)
[`delete --application`](#deleting-job-applications---delete---application) | A valid index can accept any positive integer up to the number of items in the contact or job application list where applicable. | `1`
`10` | +| `NAME` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid name can accept any non-empty value. | `Ryan Koh`
`小明` | +| `ID` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`delete`](#deleting-contacts---delete) | A valid ID has to start with a letter.

It can consist of alphanumeric and basic symbols (i.e. `a-z`, `A-Z`, `0-9`, `-`, `_`) | `woogle123`
`ryan_soc-rec` | +| `NUMBER` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid phone number can consist of only numbers with no whitespace.

It must be at least 3 digits. | `999`
`91824137` | +| `EMAIL` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid email should be in the form of `local-part@domain` where the `local-part` and `domain` must be separated by a single **@**.

The `local-part` can consist of any character except whitespace.

The `domain` name can comprise of one or more labels separated by periods, and each label can include any character except whitespace. The last `domain` label must be a minimum of two characters long. | `ryankoh@nus`
`ryan-koh@nus.edu.sg` | +| `URL` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid url should include a part in the form of `domain.tld` where the `domain` and the `tld` (top level domain) must be separated by a period. | `example.com`
`example.more.com`
`https://example.com`
`example.com/more` | +| `ADDRESS`| [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid address can accept any non-empty value.

For a contact, it designates its physical address. | `21 Lower Kent Ridge Rd` | +| `TAG` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid tag can consist of only alphanumeric characters. | `internship`
`network`
`parttime`
`jobPortal` | +| `ORG_ID` | [`add --rec`](#adding-recruiters---add---rec) | A valid organization ID is subject to the same requirements as the ID parameter.

It must belong to an Organization contact in the address book. | `woogle123`
`meta_sg-1` | +| `TITLE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid title can accept multiple words separated with spaces, as long as the characters are alphanumeric. | `Software Engineer`
`Level 3 Engineer` | +| `DESCRIPTION` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid description can accept any non-empty value. | `Senior Role`
`Hourly rate: $25` | +| `DEADLINE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid deadline should be a date in the form of `DD-MM-YYYY`.

The day (`DD`) and month (`MM`) can be either single or double digits. | `09-02-2022`
`9-2-2022`
`19-11-2022` | +| `STAGE` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid job application stage can accept only one of the three values: `resume`, `online assessment`, `interview`.

The values are ranked in the order shown. | `resume`
`online assessment`
`interview` | +| `STATUS` | [`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application) | A valid job application status can accept only one of the four values: `pending`, `offered`, `accepted`, `turned down`.

The values are ranked in the order shown. | `pending`
`offered`
`accepted`
`turned down` | +| `KEYWORD` | [`find`](#searching-contacts---find) | A valid keyword is a single word that can accept any non-empty value. | `software`
`Ryan` | -------------------------------------------------------------------------------------------------------------------- From f843f57b342e10e96011d5833666f5fa99dd2c98 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:19:18 +0800 Subject: [PATCH 09/15] Update wording for INDEX --- docs/UserGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 00c4987b737..48202097752 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -743,7 +743,7 @@ Reminds you of upcoming deadlines for job applications. | Parameter | Used by | Requirements | Examples | |-----------|---------|--------------|----------| -| `INDEX` | [`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application)
[`delete`](#deleting-contacts---delete)
[`delete --application`](#deleting-job-applications---delete---application) | A valid index can accept any positive integer up to the number of items in the contact or job application list where applicable. | `1`
`10` | +| `INDEX` | [`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`edit --application`](#editing-job-applications---edit---application)
[`delete`](#deleting-contacts---delete)
[`delete --application`](#deleting-job-applications---delete---application) | A valid index can accept any positive integer up to the number of items displayed in the contact or job application list where applicable. | `1`
`10` | | `NAME` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid name can accept any non-empty value. | `Ryan Koh`
`小明` | | `ID` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit)
[`apply`](#applying-to-organizations---apply)
[`delete`](#deleting-contacts---delete) | A valid ID has to start with a letter.

It can consist of alphanumeric and basic symbols (i.e. `a-z`, `A-Z`, `0-9`, `-`, `_`) | `woogle123`
`ryan_soc-rec` | | `NUMBER` | [`add --org`](#adding-organizations---add---org)
[`add --rec`](#adding-recruiters---add---rec)
[`edit`](#editing-contacts---edit) | A valid phone number can consist of only numbers with no whitespace.

It must be at least 3 digits. | `999`
`91824137` | From 5381ce25cb5c149eb65bc45a3ce0dd0ba740a14b Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:23:05 +0800 Subject: [PATCH 10/15] Resize image in UG --- docs/UserGuide.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 48202097752..c4abb0c2405 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -636,7 +636,9 @@ Sorts contacts or job applications for you by the specified flag. * To order your Job Applications by order of earliest deadline, you can use the command `sort --by`. * In the Application Details section of Jobby, you should see your Job Applications now ordered by most urgent deadline. -![Sort Deadline](images/sort_deadline.png) +
+ +
##### Valid examples From c60ab3e3b9ba6c10d093ebe054f06976641cefd0 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:44:34 +0800 Subject: [PATCH 11/15] Update wording and style for clear --- docs/UserGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 73555d9cafc..f795b8c13aa 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -695,7 +695,7 @@ Shows a message explaining how to access the help page. clear ``` -Clears all data from your Contacts and Job Applications. +Clears all Contact and Job Application data from Jobby. ### Exiting the program - `exit` From 312ef4241b05788d3ae0d5510c8a4912413d640c Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 21:47:54 +0800 Subject: [PATCH 12/15] Add learning outcomes for help and exit --- docs/UserGuide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index f795b8c13aa..80e214bba64 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -671,7 +671,7 @@ Reminds you of upcoming deadlines for job applications. ### Viewing help - `help` -Beginner +:trophy: How to find help on Jobby's commands Beginner ##### Format ```sh @@ -700,7 +700,7 @@ Clears all Contact and Beginner +:trophy: How to exit Jobby Beginner ##### Format ```sh From 94383105eaf029c97de4162922a05bbcc46cce82 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 22:02:11 +0800 Subject: [PATCH 13/15] Update mcnabry's PPP --- docs/team/mcnabry.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/team/mcnabry.md b/docs/team/mcnabry.md index 11300a554bf..1ad65010c77 100644 --- a/docs/team/mcnabry.md +++ b/docs/team/mcnabry.md @@ -36,13 +36,14 @@ Given below are my contributions to the project. * **Documentation**: * User Guide: - * Added documentation for features `add --recruiter`: [#??]() + * Added documentation for features `add --recruiter`: [#165](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/165) + * Added glossary and an appendix detailing acceptable features for the command parameters [#163](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/163) * Developer Guide: - * Added documentation for Recruiter class: [#??]() - * Added documentation for linking Organization and Recruiter: [#??]() + * Added documentation on the Organization-Recruiter link: [#173](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/173) + * Added appendix on effort taken to evolve AB3 to Jobby: [#190](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/190) * **Community**: - * PRs reviewed (with non-trivial review comments): - * Reported [bugs and suggestions](https://github.com/McNaBry/ped/issues) for other teams + * PRs reviewed (with non-trivial review comments): [#7](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/7), [#164](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/164) + * Reported [bugs and suggestions](https://github.com/McNaBry/ped/issues) for other teams. From c2b8af779f5fda8f02cbac72e936856d846b4da0 Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 22:02:48 +0800 Subject: [PATCH 14/15] Fix error with CJ AboutUs link --- docs/AboutUs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/AboutUs.md b/docs/AboutUs.md index 84ae82fe1e0..b44b17c506a 100644 --- a/docs/AboutUs.md +++ b/docs/AboutUs.md @@ -22,7 +22,7 @@ We are a team based in the [School of Computing, National University of Singapor [[github](https://github.com/CJ-Lee01)] -[[portfolio](team/johndoe.md)] +[[portfolio](team/cj-lee01.md)] * Role: Member From 276e435accfc82aad9451dcb56be7e9248d2e23b Mon Sep 17 00:00:00 2001 From: McNaBry Date: Mon, 13 Nov 2023 22:05:46 +0800 Subject: [PATCH 15/15] Update PPP intro --- docs/team/mcnabry.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/team/mcnabry.md b/docs/team/mcnabry.md index 1ad65010c77..a3800d7fbf1 100644 --- a/docs/team/mcnabry.md +++ b/docs/team/mcnabry.md @@ -7,9 +7,7 @@ title: Bryan's Project Portfolio Page ### Project: Jobby -Jobby is a desktop app for managing job applications and contacts, -optimized for use via a Command Line Interface (CLI) while still having the benefits of a Graphical User Interface (GUI). -Jobby can help you manage tracking your job applications and contacts in a more streamlined fashion. +Jobby is a desktop app for managing job applications and contacts. It can help you manage the tracking of your job applications and contacts in a more streamlined fashion. Given below are my contributions to the project. @@ -36,7 +34,7 @@ Given below are my contributions to the project. * **Documentation**: * User Guide: - * Added documentation for features `add --recruiter`: [#165](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/165) + * Added documentation for adding recruiter: [#165](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/165) * Added glossary and an appendix detailing acceptable features for the command parameters [#163](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/163) * Developer Guide: * Added documentation on the Organization-Recruiter link: [#173](https://github.com/AY2324S1-CS2103T-W08-3/tp/pull/173)