Skip to content

Commit d9fd3fd

Browse files
committed
Updated Tutorial Add Remark
Fix test cases issues regarding Remark functionality
1 parent cf4222f commit d9fd3fd

File tree

7 files changed

+14
-12
lines changed

7 files changed

+14
-12
lines changed

src/main/java/seedu/address/model/person/Person.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ public String toString() {
116116
.add("phone", phone)
117117
.add("email", email)
118118
.add("address", address)
119-
.add("tags", tags)
120119
.add("remark", remark)
120+
.add("tags", tags)
121121
.toString();
122122
}
123123

src/main/java/seedu/address/storage/JsonAdaptedPerson.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class JsonAdaptedPerson {
3636
@JsonCreator
3737
public JsonAdaptedPerson(@JsonProperty("name") String name, @JsonProperty("phone") String phone,
3838
@JsonProperty("email") String email, @JsonProperty("address") String address,
39-
@JsonProperty("remark") String remark, @JsonProperty("tagged") List<JsonAdaptedTag> tagged) {
39+
@JsonProperty("remark") String remark, @JsonProperty("tags") List<JsonAdaptedTag> tags) {
4040
this.name = name;
4141
this.phone = phone;
4242
this.email = email;

src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"name": "Alice Pauline",
1111
"phone": "94351253",
1212
"email": "pauline@example.com",
13-
"address": "4th street",
14-
"remark" : ""
13+
"remark" : "",
14+
"address": "4th street"
1515
} ]
1616
}

src/test/java/seedu/address/model/person/PersonTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package seedu.address.model.person;
22

3+
import static org.junit.jupiter.api.Assertions.assertEquals;
34
import static org.junit.jupiter.api.Assertions.assertFalse;
45
import static org.junit.jupiter.api.Assertions.assertTrue;
56
import static seedu.address.logic.commands.CommandTestUtil.VALID_ADDRESS_BOB;
@@ -89,11 +90,11 @@ public void equals() {
8990
assertFalse(ALICE.equals(editedAlice));
9091
}
9192

92-
/*@Test
93+
@Test
9394
public void toStringMethod() {
9495
String expected = Person.class.getCanonicalName() + "{name=" + ALICE.getName() + ", phone=" + ALICE.getPhone()
9596
+ ", email=" + ALICE.getEmail() + ", address=" + ALICE.getAddress()
96-
+ ", remark: =" + ALICE.getRemark() + ", tags=" + ALICE.getTags() + "}";
97+
+ ", remark=" + ALICE.getRemark() + ", tags=" + ALICE.getTags() + "}";
9798
assertEquals(expected, ALICE.toString());
98-
}*/
99+
}
99100
}

src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import static seedu.address.testutil.Assert.assertThrows;
66
import static seedu.address.testutil.TypicalPersons.BENSON;
77

8+
import java.util.ArrayList;
89
import java.util.List;
910
import java.util.stream.Collectors;
1011

@@ -102,12 +103,12 @@ public void toModelType_nullAddress_throwsIllegalValueException() {
102103
assertThrows(IllegalValueException.class, expectedMessage, person::toModelType);
103104
}
104105

105-
/*@Test
106+
@Test
106107
public void toModelType_invalidTags_throwsIllegalValueException() {
107108
List<JsonAdaptedTag> invalidTags = new ArrayList<>(VALID_TAGS);
108109
invalidTags.add(new JsonAdaptedTag(INVALID_TAG));
109110
JsonAdaptedPerson person =
110111
new JsonAdaptedPerson(VALID_NAME, VALID_PHONE, VALID_EMAIL, VALID_ADDRESS, VALID_REMARK, invalidTags);
111112
assertThrows(IllegalValueException.class, person::toModelType);
112-
}*/
113+
}
113114
}

src/test/java/seedu/address/testutil/PersonBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class PersonBuilder {
2121
public static final String DEFAULT_PHONE = "85355255";
2222
public static final String DEFAULT_EMAIL = "amy@gmail.com";
2323
public static final String DEFAULT_ADDRESS = "123, Jurong West Ave 6, #08-111";
24-
public static final String DEFAULT_REMARK = "She likes aardvarks.";
24+
public static final String DEFAULT_REMARK = "Likes baseball";
2525

2626
private Name name;
2727
private Phone phone;

src/test/java/seedu/address/testutil/TypicalPersons.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ public class TypicalPersons {
2525

2626
public static final Person ALICE = new PersonBuilder().withName("Alice Pauline")
2727
.withAddress("123, Jurong West Ave 6, #08-111").withEmail("alice@example.com")
28-
.withPhone("94351253").withRemark("She likes aardvarks.")
28+
.withPhone("94351253").withRemark("Likes baseball")
2929
.withTags("friends").build();
3030
public static final Person BENSON = new PersonBuilder().withName("Benson Meier")
3131
.withAddress("311, Clementi Ave 2, #02-25")
32-
.withEmail("johnd@example.com").withPhone("98765432").withRemark("He can't take beer!")
32+
.withEmail("johnd@example.com").withPhone("98765432").withRemark("Likes drinking")
3333
.withTags("owesMoney", "friends").build();
3434
public static final Person CARL = new PersonBuilder().withName("Carl Kurz").withPhone("95352563")
3535
.withEmail("heinz@example.com").withAddress("wall street").build();

0 commit comments

Comments
 (0)