Skip to content

Commit 3a5aefa

Browse files
committed
Add more tests
1 parent d786cec commit 3a5aefa

File tree

4 files changed

+81
-0
lines changed

4 files changed

+81
-0
lines changed

src/main/java/seedu/address/model/reminder/ReminderList.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ public boolean equals(Object other) {
6666
return false;
6767
}
6868

69+
if (!remindersList.equals(otherReminderList.remindersList)) {
70+
return false;
71+
}
72+
6973
return true;
7074
}
7175
}

src/test/java/seedu/address/model/person/PersonTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,11 @@ public void scheduleStringFormat() {
177177
missedAlice.scheduleStringFormat());
178178
}
179179

180+
@Test
181+
public void birthdayStringFormat() {
182+
assertEquals(ALICE.birthdayStringFormat(), ALICE.getBirthday() + " - " + ALICE.getName());
183+
}
184+
180185
@Test
181186
public void hasUpcomingBirthday() {
182187
Person upcomingAlice = new PersonBuilder(ALICE).withBirthday(DateUtil.parseDateToString(

src/test/java/seedu/address/model/reminder/ReminderListTest.java

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package seedu.address.model.reminder;
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static seedu.address.testutil.TypicalPersons.ALICE;
45

56
import java.time.LocalDate;
67
import java.time.LocalDateTime;
@@ -9,6 +10,7 @@
910

1011
import javafx.collections.FXCollections;
1112
import javafx.collections.ObservableList;
13+
import seedu.address.commons.util.DateUtil;
1214
import seedu.address.model.person.Person;
1315
import seedu.address.testutil.PersonBuilder;
1416

@@ -38,4 +40,73 @@ public void toStringMethodSchedule() {
3840
assertEquals(reminderList.toString(), person1.scheduleStringFormat()
3941
+ "\n" + person2.scheduleStringFormat() + "\n");
4042
}
43+
44+
@Test
45+
public void toStringMethodBirthday() {
46+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
47+
Person person1 = new PersonBuilder().withBirthday(DateUtil.parseDateToString(
48+
LocalDate.of(2001, 1, 1))).build();
49+
remindersList.add(person1);
50+
Person person2 = new PersonBuilder().withBirthday(DateUtil.parseDateToString(
51+
LocalDate.of(2002, 2, 2))).build();
52+
remindersList.add(person2);
53+
ReminderList reminderList = new ReminderList(ReminderType.BIRTHDAYS, remindersList);
54+
assertEquals(reminderList.toString(), person1.birthdayStringFormat()
55+
+ "\n" + person2.birthdayStringFormat() + "\n");
56+
}
57+
58+
@Test
59+
public void equals_sameObject_true() {
60+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
61+
ReminderList reminderList = new ReminderList(ReminderType.LAST_MET, remindersList);
62+
assertEquals(reminderList, reminderList);
63+
}
64+
65+
@Test
66+
public void equals_sameValues_true() {
67+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
68+
ReminderList reminderList1 = new ReminderList(ReminderType.LAST_MET, remindersList);
69+
ReminderList reminderList2 = new ReminderList(ReminderType.LAST_MET, remindersList);
70+
assertEquals(reminderList1, reminderList2);
71+
}
72+
73+
@Test
74+
public void equals_differentType_false() {
75+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
76+
ReminderList reminderList = new ReminderList(ReminderType.LAST_MET, remindersList);
77+
assertEquals(reminderList.equals(1), false);
78+
}
79+
80+
@Test
81+
public void equals_differentReminderType_false() {
82+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
83+
ReminderList reminderList1 = new ReminderList(ReminderType.LAST_MET, remindersList);
84+
ReminderList reminderList2 = new ReminderList(ReminderType.SCHEDULES, remindersList);
85+
assertEquals(reminderList1.equals(reminderList2), false);
86+
}
87+
88+
@Test
89+
public void equals_null_false() {
90+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
91+
ReminderList reminderList = new ReminderList(ReminderType.LAST_MET, remindersList);
92+
assertEquals(reminderList.equals(null), false);
93+
}
94+
95+
@Test
96+
public void equals_differentRemindersList_false() {
97+
ObservableList<Person> remindersList1 = FXCollections.observableArrayList();
98+
ObservableList<Person> remindersList2 = FXCollections.observableArrayList();
99+
remindersList2.add(ALICE);
100+
ReminderList reminderList1 = new ReminderList(ReminderType.LAST_MET, remindersList1);
101+
ReminderList reminderList2 = new ReminderList(ReminderType.LAST_MET, remindersList2);
102+
assertEquals(reminderList1.equals(reminderList2), false);
103+
}
104+
105+
@Test
106+
public void equals_sameRemindersList_true() {
107+
ObservableList<Person> remindersList = FXCollections.observableArrayList();
108+
ReminderList reminderList1 = new ReminderList(ReminderType.LAST_MET, remindersList);
109+
ReminderList reminderList2 = new ReminderList(ReminderType.LAST_MET, remindersList);
110+
assertEquals(reminderList1.equals(reminderList2), true);
111+
}
41112
}

src/test/java/seedu/address/model/reminder/ReminderTypeTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,6 @@ public class ReminderTypeTest {
99
public void toStringMethod() {
1010
assertEquals("Last Met", ReminderType.LAST_MET.toString());
1111
assertEquals("Schedules", ReminderType.SCHEDULES.toString());
12+
assertEquals("Birthday", ReminderType.BIRTHDAYS.toString());
1213
}
1314
}

0 commit comments

Comments
 (0)