Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AddExpenseCommand's execution to avoid nested command block #80

Closed
DanLinhHuynh-Niwashi opened this issue Oct 19, 2024 · 0 comments
Closed

Refactor AddExpenseCommand's execution to avoid nested command block #80

DanLinhHuynh-Niwashi opened this issue Oct 19, 2024 · 0 comments
Assignees
@YukeeHong
Labels
type.CodeQuality type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Milestone
v2.0

Comments

@DanLinhHuynh-Niwashi
Copy link 

          This function seems to have multiple functionalities embedded. You can consider refactoring this.

Originally posted by @joshuan98 in nus-cs2113-AY2425S1#6 (comment)

You can split the processing to different methods.
@DanLinhHuynh-Niwashi DanLinhHuynh-Niwashi added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new type.CodeQuality labels Oct 19, 2024
@DanLinhHuynh-Niwashi DanLinhHuynh-Niwashi added this to the v2.0 milestone Oct 19, 2024
@YukeeHong YukeeHong self-assigned this Oct 27, 2024
@DanLinhHuynh-Niwashi DanLinhHuynh-Niwashi linked a pull request Oct 28, 2024 that will close this issue
Refractor welcome message and Update a spending category #94
Merged
@DanLinhHuynh-Niwashi DanLinhHuynh-Niwashi removed a link to a pull request Oct 28, 2024
Refractor welcome message and Update a spending category #94
Merged
@Oshen27 Oshen27 closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YukeeHong YukeeHong

Labels
type.CodeQuality type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@Oshen27 @YukeeHong @DanLinhHuynh-Niwashi