Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multilingual support #32

Open
AaronSadlerUK opened this issue Oct 1, 2021 · 6 comments
Open

Improve multilingual support #32

AaronSadlerUK opened this issue Oct 1, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AaronSadlerUK
Copy link
Owner

Currently the multilingual support is clunky to say the least.

It would be nice to be able to choose any enabled language in the node picker, handle the fallbacks gracefully and improve the underlying code for the multilingual part

@AaronSadlerUK AaronSadlerUK added enhancement New feature or request help wanted Extra attention is needed labels Oct 1, 2021
@olibos
Copy link

olibos commented Oct 5, 2021

Hello,

I was just looking at your package for a new Umbraco project, I think your package is really interesting!
But I had the same issue when I'm trying it on few pages with multiple culture variations...

Do you have any idea to improve it? Maybe I can help.

@AaronSadlerUK
Copy link
Owner Author

The biggest improvement would be to add a language dropdown to the node picker, so you could switch between languages.

Also I know there is a bug where if you don't specify a menu in a language, and then it falls back, the link gets added with no title.

But other than that, I'm not sure on use cases, other than it's clunky 😂

Open to ideas at this point

@mrrm
Copy link

mrrm commented Mar 31, 2023

When I build a menu of items that allow "vary by culture", the menu links are not shown

@mrrm
Copy link

mrrm commented Apr 6, 2023

Fixed passing "" in the culture. But when I clean backoffice cache, it disappears again

@AaronSadlerUK
Copy link
Owner Author

Have you tried passing in the current culture when rendering out?

@mrrm
Copy link

mrrm commented Apr 22, 2023

yes, I've tried. the same issue when reloading cache in the backoffice happens. Just the labels in the menu navigation are shown, not the links. I'm using 1.1.4 version on Umbraco 8.16.0 . The issue happens when the nav was built using link to pages(nodes), not when the links use full url. Not all page nodes have content for the second defined language. To allow the complete navigation appears(including links) is necessary to re-run the application o re-deploying. The site is hosted in azure, I have 2 sites using multisite feature on Umb8. I have 2 domains to access the same site. In one domain the issue occurs, in the other the menu works okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants